From: David Edmondson <dme@dme.org>
To: Chuan Zheng <zhengchuan@huawei.com>,
quintela@redhat.com, eblake@redhat.com, dgilbert@redhat.com,
berrange@redhat.com
Cc: alex.chen@huawei.com, ann.zhuangyanying@huawei.com,
zhang.zhanghailiang@huawei.com, xiexiangyou@huawei.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH v6 00/12] *** A Method for evaluating dirty page rate ***
Date: Mon, 31 Aug 2020 10:05:30 +0100 [thread overview]
Message-ID: <m2h7sjchid.fsf@dme.org> (raw)
In-Reply-To: <1598669577-76914-1-git-send-email-zhengchuan@huawei.com>
Trying to think like a control plane developer and user (of which I am
neither) raised some questions about the overall interface provided
here. If everyone else is happy with the current interface, then I'll
shut up :-)
It seems like it should be possible to query the last measured dirty
rate at any time. In particular, it should be possible to query the
value before any rate has been measured (either returning an error, or
if that is unpalatable perhaps a result with a zero interval to indicate
"this data isn't useful"), but also *during* a subsequent measurement
period.
That is, the result of the previous measurement should always be
available on demand and a measurement becomes "current" when it
completes.
Given that we allow the caller to specify the measurement interval, some
callers might specify a long period. As only one measurement can be
taken at a time, a long running measurement rules out taking a short
measurement. That's probably okay, but does lead me to wonder whether
the API should include a mechanism allowing the cancellation of an
in-progress measurement.
dme.
--
I can't explain, you would not understand. This is not how I am.
next prev parent reply other threads:[~2020-08-31 9:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 2:52 [PATCH v6 00/12] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 01/12] migration/dirtyrate: setup up query-dirtyrate framwork Chuan Zheng
2020-08-31 8:54 ` David Edmondson
2020-08-31 11:07 ` Zheng Chuan
2020-08-29 2:52 ` [PATCH v6 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info Chuan Zheng
2020-08-31 9:06 ` David Edmondson
2020-08-31 9:07 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 04/12] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-08-31 9:07 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 06/12] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-08-31 9:08 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 07/12] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-08-31 9:10 ` David Edmondson
2020-08-31 11:10 ` Zheng Chuan
2020-08-29 2:52 ` [PATCH v6 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-08-31 9:12 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 09/12] migration/dirtyrate: Implement set_sample_page_period() and get_sample_page_period() Chuan Zheng
2020-08-31 9:12 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-08-31 9:13 ` David Edmondson
2020-08-31 11:24 ` Zheng Chuan
2020-08-31 12:01 ` David Edmondson
2020-08-29 2:52 ` [PATCH v6 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-08-29 2:52 ` [PATCH v6 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug Chuan Zheng
2020-08-31 9:14 ` David Edmondson
2020-08-31 9:05 ` David Edmondson [this message]
2020-08-31 9:55 ` [PATCH v6 00/12] *** A Method for evaluating dirty page rate *** Zheng Chuan
2020-08-31 10:08 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2h7sjchid.fsf@dme.org \
--to=dme@dme.org \
--cc=alex.chen@huawei.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiexiangyou@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.