All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew W Elble <aweits@rit.edu>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: Re: NMI/soft lockup in nfs_delegation_need_return()
Date: Wed, 04 Mar 2015 09:06:18 -0500	[thread overview]
Message-ID: <m2h9u06en9.fsf@discipline.rit.edu> (raw)
In-Reply-To: <1424964991.10136.8.camel@primarydata.com> (Trond Myklebust's message of "Thu, 26 Feb 2015 10:36:31 -0500")

Trond,

   Some feedback on patches you have in your devel branch. We've been
  seeing a problem where the server/client conversation after a few
  hours (usually after we leave the environment overnight) becomes
  nothing but sequence operations back and forth with the server
  continually asserting SEQ4_STATUS_RECALLABLE_STATE_REVOKED. The
  client is in an unusable state which can rapidly degrade to a
  lock or crash. (We've seen this with both 3.18.8 and RHEL7
  3.10.0-123.20.1.el7.x86_64)

  Cherry-picking these:

  9f0f8e12c48e4bb89192a0de876c77dc1fbfaa75
    NFSv4: Pin the superblock while we're returning the delegation

  ade04647dd56881e285983af3db702d56ee97e86
    NFSv4: Ensure we honour NFS_DELEGATION_RETURNING in nfs_inode_set_delegation()

  b04b22f4ca691280f0ab3f77954f5a21500881e7
    NFSv4: Ensure that we don't reap a delegation that is being returned

  ec3ca4e57e00d52ff724b0ae49f4489667a9c311
    NFSv4: Ensure we skip delegations that are already being returned

  Plus this:

  ea7c38fef0b774a5dc16fb0ca5935f0ae8568176
    NFSv4: Ensure we reference the inode for return-on-close in delegreturn

  And applying to 3.18.8 has eliminated this from manifesting for at
  least last night.

  Thanks,

Andy

-- 
Andrew W. Elble
aweits@discipline.rit.edu
Infrastructure Engineer, Communications Technical Lead
Rochester Institute of Technology
PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912

      parent reply	other threads:[~2015-03-04 14:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 13:04 NMI/soft lockup in nfs_delegation_need_return() David Howells
2014-09-25 13:07 ` David Howells
2014-09-25 14:15 ` Trond Myklebust
2015-02-26 10:45   ` David Howells
2015-02-26 15:36     ` Trond Myklebust
2015-02-26 16:51       ` David Howells
2015-02-26 16:59         ` David Howells
2015-02-28 15:21           ` Trond Myklebust
2015-03-04 13:21             ` David Howells
2015-03-04 14:45             ` David Howells
2015-03-04 14:06       ` Andrew W Elble [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2h9u06en9.fsf@discipline.rit.edu \
    --to=aweits@rit.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.