All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Aaron Lu <aaron.lu@amd.com>
Cc: linux-mmc@vger.kernel.org, Philip Rakity <prakity@marvell.com>
Subject: Re: [PATCH] mmc: sdhci: deactivate tuning timer when host is suspending
Date: Mon, 02 Jan 2012 19:02:27 -0500	[thread overview]
Message-ID: <m2hb0dpsa4.fsf@bob.laptop.org> (raw)
In-Reply-To: <1324959750-18203-1-git-send-email-aaron.lu@amd.com> (Aaron Lu's message of "Tue, 27 Dec 2011 12:22:30 +0800")

Hi,

On Mon, Dec 26 2011, Aaron Lu wrote:
> From: Philip Rakity <prakity@marvell.com>
>
> Since we are suspending, the tuning timer should be deactivated.
>
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> Acked-by: Aaron Lu <aaron.lu@amd.com>
> ---
>  drivers/mmc/host/sdhci.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ab6018f..1abbd26 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2347,8 +2347,7 @@ int sdhci_suspend_host(struct sdhci_host *host)
>  	if (host->version >= SDHCI_SPEC_300 && host->tuning_count &&
>  	    host->tuning_mode == SDHCI_TUNING_MODE_1) {
>  		host->flags &= ~SDHCI_NEEDS_RETUNING;
> -		mod_timer(&host->tuning_timer, jiffies +
> -			host->tuning_count * HZ);
> +		del_timer_sync(&host->tuning_timer);
>  	}
>  
>  	ret = mmc_suspend_host(host->mmc);

Pushed to mmc-next for 3.3 with a stable@ tag, thanks.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2012-01-03  0:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27  4:22 [PATCH] mmc: sdhci: deactivate tuning timer when host is suspending Aaron Lu
2012-01-03  0:02 ` Chris Ball [this message]
2012-01-04  1:14   ` Aaron Lu
2012-01-04  1:24     ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2hb0dpsa4.fsf@bob.laptop.org \
    --to=cjb@laptop.org \
    --cc=aaron.lu@amd.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.