From: Andreas Schwab <schwab@linux-m68k.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Michael J Gruber <git@drmicha.warpmail.net>,
Brandon Casey <casey@nrlssc.navy.mil>,
git@vger.kernel.org, PWalker752@aol.com, newsletter@dirk.my1.cc,
bruce.stephens@isode.com, Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH 2/2] Makefile: work around ksh's failure to handle missing list argument to for loop
Date: Mon, 05 Jul 2010 22:00:12 +0200 [thread overview]
Message-ID: <m2hbkd66nn.fsf@igel.home> (raw)
In-Reply-To: <7vy6dpyeqf.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 05 Jul 2010 11:18:16 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> + $(foreach p,$(REMOTE_CURL_ALIASES), \
> + { \
> + $(RM) "$$execdir/$p" && \
> + ln "$$execdir/git-remote-http$X" "$$execdir/$p" 2>/dev/null || \
> + ln -s "git-remote-http$X" "$$execdir/$p" 2>/dev/null || \
> + cp "$$execdir/git-remote-http$X" "$$execdir/$p" || exit; \
> + } && ) : \
^^
> ./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
Missing && at the end of the preceding line (otherwise the last line is
effectively commented out).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-07-05 20:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 13:35 installation issue when building with NO_CURL=YesPlease Paul Walker
2010-05-26 13:58 ` Michael J Gruber
2010-05-26 14:41 ` Paul Walker
2010-05-26 13:58 ` Ramkumar Ramachandra
2010-05-26 14:15 ` Paul Walker
2010-05-26 14:24 ` [PATCH] Makefile: reenable install with NO_CURL Michael J Gruber
2010-05-26 18:27 ` installation issue when building with NO_CURL=YesPlease Dirk Süsserott
2010-05-26 18:45 ` Bruce Stephens
2010-05-26 19:03 ` Dirk Süsserott
2010-07-02 18:50 ` [PATCH 1/2] Makefile: remove some unnecessary curly braces Brandon Casey
2010-07-02 18:50 ` [PATCH 2/2] Makefile: work around ksh's failure to handle missing list argument to for loop Brandon Casey
2010-07-03 6:21 ` Raja R Harinath
2010-07-04 18:37 ` Michael J Gruber
2010-07-05 6:19 ` Johannes Sixt
2010-07-05 8:14 ` Michael J Gruber
2010-07-05 9:15 ` Johannes Sixt
2010-07-05 9:31 ` Michael J Gruber
2010-07-05 18:18 ` Junio C Hamano
2010-07-05 20:00 ` Andreas Schwab [this message]
2010-07-05 21:29 ` Brandon Casey
2010-07-06 2:36 ` Junio C Hamano
2010-07-06 21:56 ` [PATCH 2/2 v2] " Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2hbkd66nn.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=PWalker752@aol.com \
--cc=bruce.stephens@isode.com \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=newsletter@dirk.my1.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.