From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Subject: Re: H8/300 target support patch Date: Sat, 21 Feb 2004 02:58:39 +0900 Sender: linux-ide-owner@vger.kernel.org Message-ID: References: <200402191734.49496.bzolnier@elka.pw.edu.pl> <200402201625.42842.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from p062096.ppp.asahi-net.or.jp ([221.113.62.96]:44013 "EHLO mitou.ysato.dip.jp") by vger.kernel.org with ESMTP id S261355AbUBTR6m (ORCPT ); Fri, 20 Feb 2004 12:58:42 -0500 In-Reply-To: <200402201625.42842.bzolnier@elka.pw.edu.pl> List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Benjamin Herrenschmidt , linux-ide@vger.kernel.org At Fri, 20 Feb 2004 16:25:42 +0100, Bartlomiej Zolnierkiewicz wrote: > > On Friday 20 of February 2004 13:28, Yoshinori Sato wrote: > > At Thu, 19 Feb 2004 17:34:49 +0100, > > > > Bartlomiej Zolnierkiewicz wrote: > > > Hi, > > > > > > Can you send updated patch? > > > I am lost in incremental changes. :-) > > > > > > Thanks. > > > > Difference with linux-2.6.3. > > Hi, > > Your patch lacks Kconfig entries for CONFIG_H8300_IDE_{BASE,ALT,IRQNO} > and they are not present in kernel 2.6.3? It is not done merge yet. I compound it with other corrections and will submit it. > Are you aware that you can't build kernel which will support both controllers? > Not an issue if you can't build kernel which supports both this boards. :-) > > I cleaned up patch a bit, changelog: > - h8max_ide.c and aki3068_ide.c merged into ide-h8300.c Because there is a target different in implementation, correspondence becomes easy separated. > - added #if !defined(__H8300H__) to ide-proc.c > (only place where ->OUTL is used, ->INL is unused in generic IDE code) "__H8300S__" becomes the same condition, too. > - __ide_outl() and __ide_inl() removed > - redundant includes removed > - init driver through initcall (so no need to make changes in ide.c) It seems to have been overwritten with default_hwif_iops setting of h8300_hwif_iops in module_init. > Not tested et all, I don't know whether it compiles. :-) > -- Yoshinori Sato