All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: meson: organize devices in their corresponding busses
Date: Fri, 19 May 2017 15:49:12 -0700	[thread overview]
Message-ID: <m2inkw4g47.fsf@baylibre.com> (raw)
In-Reply-To: <20170417213938.22626-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Mon, 17 Apr 2017 23:39:37 +0200")

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> The Amlogic Meson SoCs have most of the internal peripherals organized
> in busses. Use them to make the dts easier to read and to avoid
> duplicated register (bus) offset definitions.
>
> The bus information is taken from the vendor kernel:
> 	#define IO_CBUS_PHY_BASE        0xc1100000  ///2M
> 	#define IO_AOBUS_PHY_BASE       0xc8100000  ///1M
>
> There are more internal busses (such as the abp bus which seems to
> contain audio, HDMI and Mali registers), but since we don't have
> drivers for them yet these are not added (yet).
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

I tested this series on my meson8b-odroidc1 and it boots fine.

Series looks fine to me, except...

[...]

>  
>  		ethmac: ethernet at c9410000 {
>  			compatible = "amlogic,meson6-dwmac", "snps,dwmac";
>  			reg = <0xc9410000 0x10000
> -			       0xc1108108 0x4>;
> +			0xc1108108 0x4>;

stray tab removal?

I fixed that up locally and applied to v4.13/dt64 branch.

Thanks for the patches!

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: meson: organize devices in their corresponding busses
Date: Fri, 19 May 2017 15:49:12 -0700	[thread overview]
Message-ID: <m2inkw4g47.fsf@baylibre.com> (raw)
In-Reply-To: <20170417213938.22626-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Mon, 17 Apr 2017 23:39:37 +0200")

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> The Amlogic Meson SoCs have most of the internal peripherals organized
> in busses. Use them to make the dts easier to read and to avoid
> duplicated register (bus) offset definitions.
>
> The bus information is taken from the vendor kernel:
> 	#define IO_CBUS_PHY_BASE        0xc1100000  ///2M
> 	#define IO_AOBUS_PHY_BASE       0xc8100000  ///1M
>
> There are more internal busses (such as the abp bus which seems to
> contain audio, HDMI and Mali registers), but since we don't have
> drivers for them yet these are not added (yet).
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

I tested this series on my meson8b-odroidc1 and it boots fine.

Series looks fine to me, except...

[...]

>  
>  		ethmac: ethernet at c9410000 {
>  			compatible = "amlogic,meson6-dwmac", "snps,dwmac";
>  			reg = <0xc9410000 0x10000
> -			       0xc1108108 0x4>;
> +			0xc1108108 0x4>;

stray tab removal?

I fixed that up locally and applied to v4.13/dt64 branch.

Thanks for the patches!

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Martin Blumenstingl
	<martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: dts: meson: organize devices in their corresponding busses
Date: Fri, 19 May 2017 15:49:12 -0700	[thread overview]
Message-ID: <m2inkw4g47.fsf@baylibre.com> (raw)
In-Reply-To: <20170417213938.22626-2-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> (Martin Blumenstingl's message of "Mon, 17 Apr 2017 23:39:37 +0200")

Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes:

> The Amlogic Meson SoCs have most of the internal peripherals organized
> in busses. Use them to make the dts easier to read and to avoid
> duplicated register (bus) offset definitions.
>
> The bus information is taken from the vendor kernel:
> 	#define IO_CBUS_PHY_BASE        0xc1100000  ///2M
> 	#define IO_AOBUS_PHY_BASE       0xc8100000  ///1M
>
> There are more internal busses (such as the abp bus which seems to
> contain audio, HDMI and Mali registers), but since we don't have
> drivers for them yet these are not added (yet).
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>

I tested this series on my meson8b-odroidc1 and it boots fine.

Series looks fine to me, except...

[...]

>  
>  		ethmac: ethernet@c9410000 {
>  			compatible = "amlogic,meson6-dwmac", "snps,dwmac";
>  			reg = <0xc9410000 0x10000
> -			       0xc1108108 0x4>;
> +			0xc1108108 0x4>;

stray tab removal?

I fixed that up locally and applied to v4.13/dt64 branch.

Thanks for the patches!

Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-05-19 22:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 21:39 [PATCH 0/2] Amlogic Meson (32-bit) .dts cleanups Martin Blumenstingl
2017-04-17 21:39 ` Martin Blumenstingl
2017-04-17 21:39 ` Martin Blumenstingl
2017-04-17 21:39 ` [PATCH 1/2] ARM: dts: meson: organize devices in their corresponding busses Martin Blumenstingl
2017-04-17 21:39   ` Martin Blumenstingl
2017-04-17 21:39   ` Martin Blumenstingl
2017-05-19 22:49   ` Kevin Hilman [this message]
2017-05-19 22:49     ` Kevin Hilman
2017-05-19 22:49     ` Kevin Hilman
2017-05-20  8:45     ` Martin Blumenstingl
2017-05-20  8:45       ` Martin Blumenstingl
2017-05-20  8:45       ` Martin Blumenstingl
2017-05-26 18:20       ` Kevin Hilman
2017-05-26 18:20         ` Kevin Hilman
2017-05-26 18:20         ` Kevin Hilman
2017-04-17 21:39 ` [PATCH 2/2] ARM: dts: meson8b: inherit meson.dtsi from meson8b.dtsi Martin Blumenstingl
2017-04-17 21:39   ` Martin Blumenstingl
2017-04-17 21:39   ` Martin Blumenstingl
2017-05-06 17:29 ` [PATCH 0/2] Amlogic Meson (32-bit) .dts cleanups Martin Blumenstingl
2017-05-06 17:29   ` Martin Blumenstingl
2017-05-06 17:29   ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2inkw4g47.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.