All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 0/10] mmc: meson-gx: series with smaller improvements
Date: Fri, 03 Mar 2017 13:19:47 -0800	[thread overview]
Message-ID: <m2innq12j0.fsf@baylibre.com> (raw)
In-Reply-To: <62912f3d-2307-cfff-3c69-c8b8ffaeb474@gmail.com> (Heiner Kallweit's message of "Fri, 3 Mar 2017 20:49:33 +0100")

Heiner Kallweit <hkallweit1@gmail.com> writes:

> New series is limited to smaller refactorings w/o functional changes.

I'd reviewed this series before, but hadn't actually tested it until
today.  I applied this series onto today's linux-next, and tested on
meson-gxbb-odroidc2 and the kernel hangs up right after:

       meson-gx-mmc d0072000.mmc: Got CD GPIO

with no error message or oops/backtrace etc.

Could you clarify how you are testing this, on what tree/branch, on what
hardware etc.?

Also, in the cover letter, it's customary to include a summary of what
changed since the previous version(s)

Kevin

> Heiner Kallweit (10):
>   mmc: meson-gx: simplify bounce buffer setting in meson_mmc_start_cmd
>   mmc: meson-gx: make two functions return void
>   mmc: meson-gx: remove unused members irq, ocr_mask from struct meson_host
>   mmc: meson-gx: remove unneeded variable in meson_mmc_clk_init
>   mmc: meson-gx: remove member parent_mux from struct meson_host
>   mmc: meson-gx: remove unneeded meson_mmc_clk_set in meson_mmc_clk_init
>   mmc: meson-gx: remove unneeded devm_kstrdup in meson_mmc_clk_init
>   mmc: meson-gx: improve initial configuration
>   mmc: meson-gx: remove member mrq from struct meson_host
>   mmc: meson-gx: replace magic timeout numbers with constants
>
>  drivers/mmc/host/meson-gx-mmc.c | 126 ++++++++++++++++------------------------
>  1 file changed, 50 insertions(+), 76 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4 0/10] mmc: meson-gx: series with smaller improvements
Date: Fri, 03 Mar 2017 13:19:47 -0800	[thread overview]
Message-ID: <m2innq12j0.fsf@baylibre.com> (raw)
In-Reply-To: <62912f3d-2307-cfff-3c69-c8b8ffaeb474@gmail.com> (Heiner Kallweit's message of "Fri, 3 Mar 2017 20:49:33 +0100")

Heiner Kallweit <hkallweit1@gmail.com> writes:

> New series is limited to smaller refactorings w/o functional changes.

I'd reviewed this series before, but hadn't actually tested it until
today.  I applied this series onto today's linux-next, and tested on
meson-gxbb-odroidc2 and the kernel hangs up right after:

       meson-gx-mmc d0072000.mmc: Got CD GPIO

with no error message or oops/backtrace etc.

Could you clarify how you are testing this, on what tree/branch, on what
hardware etc.?

Also, in the cover letter, it's customary to include a summary of what
changed since the previous version(s)

Kevin

> Heiner Kallweit (10):
>   mmc: meson-gx: simplify bounce buffer setting in meson_mmc_start_cmd
>   mmc: meson-gx: make two functions return void
>   mmc: meson-gx: remove unused members irq, ocr_mask from struct meson_host
>   mmc: meson-gx: remove unneeded variable in meson_mmc_clk_init
>   mmc: meson-gx: remove member parent_mux from struct meson_host
>   mmc: meson-gx: remove unneeded meson_mmc_clk_set in meson_mmc_clk_init
>   mmc: meson-gx: remove unneeded devm_kstrdup in meson_mmc_clk_init
>   mmc: meson-gx: improve initial configuration
>   mmc: meson-gx: remove member mrq from struct meson_host
>   mmc: meson-gx: replace magic timeout numbers with constants
>
>  drivers/mmc/host/meson-gx-mmc.c | 126 ++++++++++++++++------------------------
>  1 file changed, 50 insertions(+), 76 deletions(-)

  parent reply	other threads:[~2017-03-03 21:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 19:49 [PATCH v4 0/10] mmc: meson-gx: series with smaller improvements Heiner Kallweit
2017-03-03 19:49 ` Heiner Kallweit
2017-03-03 19:51 ` [PATCH v4 1/10] mmc: meson-gx: simplify bounce buffer setting in meson_mmc_start_cmd Heiner Kallweit
2017-03-03 19:51   ` Heiner Kallweit
2017-03-03 19:52 ` [PATCH v4 2/10] mmc: meson-gx: make two functions return void Heiner Kallweit
2017-03-03 19:52   ` Heiner Kallweit
2017-03-03 19:53 ` [PATCH v4 3/10] mmc: meson-gx: remove unused members irq, ocr_mask from struct meson_host Heiner Kallweit
2017-03-03 19:53   ` Heiner Kallweit
2017-03-03 19:54 ` [PATCH v4 4/10] mmc: meson-gx: remove unneeded variable in meson_mmc_clk_init Heiner Kallweit
2017-03-03 19:54   ` Heiner Kallweit
2017-03-03 19:55 ` [PATCH v4 5/10] mmc: meson-gx: remove member parent_mux from struct meson_host Heiner Kallweit
2017-03-03 19:55   ` Heiner Kallweit
2017-03-03 19:56 ` [PATCH v4 6/10] mmc: meson-gx: fix error path in meson_mmc_clk_init / meson_mmc_probe Heiner Kallweit
2017-03-03 19:56   ` Heiner Kallweit
2017-03-03 19:57 ` [PATCH v4 7/10] mmc: meson-gx: remove unneeded devm_kstrdup in meson_mmc_clk_init Heiner Kallweit
2017-03-03 19:57   ` Heiner Kallweit
2017-03-03 19:58 ` [PATCH v4 8/10] mmc: meson-gx: improve initial configuration Heiner Kallweit
2017-03-03 19:58   ` Heiner Kallweit
2017-03-03 19:59 ` [PATCH v4 9/10] mmc: meson-gx: remove member mrq from struct meson_host Heiner Kallweit
2017-03-03 19:59   ` Heiner Kallweit
2017-03-03 20:00 ` [PATCH v4 10/10] mmc: meson-gx: replace magic timeout numbers with constants Heiner Kallweit
2017-03-03 20:00   ` Heiner Kallweit
2017-03-03 21:19 ` Kevin Hilman [this message]
2017-03-03 21:19   ` [PATCH v4 0/10] mmc: meson-gx: series with smaller improvements Kevin Hilman
2017-03-03 22:54   ` Heiner Kallweit
2017-03-03 22:54     ` Heiner Kallweit
2017-03-04  5:33     ` Kevin Hilman
2017-03-04  5:33       ` Kevin Hilman
2017-03-04  5:36       ` Kevin Hilman
2017-03-04  5:36         ` Kevin Hilman
     [not found] <c1a6c969-2426-4069-6836-fcbe4f4bdebd@gmail.com>
2017-03-04  9:56 ` Heiner Kallweit
2017-03-04  9:56   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2innq12j0.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.