From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Makefile: fix HAVE_VENDOR_COMMON_LIB
Date: Fri, 17 Aug 2012 18:18:13 +0200 [thread overview]
Message-ID: <m2ipcha3wa.fsf@lamuella.denx.de> (raw)
In-Reply-To: <20120814201238.551c32e0284cba97ffe0481c@freescale.com> (Kim Phillips's message of "Tue, 14 Aug 2012 20:12:38 -0500")
Hi,
> On Tue, 14 Aug 2012 13:44:29 +0200
> Daniel Schwierzeck <daniel.schwierzeck@gmail.com> wrote:
>
>> From: Scott Wood <scottwood@freescale.com>
>>
>> Commit 8b5a02640adf77301f943e8754992c50df004e8a ("Makefile: cosmetic:
>> optimize usage of LIBS-y") broke the build of boards that have a board
>> vendor "common" directory, by introducing a space between "LIBS-" and
>> "y".
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>> ---
>> Changes vor v2:
>> - fix the wrong spaces also in spl/Makefile
>>
>> Tested with:
>> MAKEALL spear600
>> MAKEALL -s omap3
>> MAKEALL -s omap4
>> ---
>
> this fixes newly broken mpc83xx builds, e.g.:
>
> Configuring for MPC832XEMDS_ATM - Board: MPC832XEMDS, Options:
> PQ_MDS_PIB=1,PQ_MDS_PIB_ATM=1
> make: *** [u-boot] Error 1
> powerpc-fsl-linux-size: './u-boot': No such file
> board/freescale/mpc832xemds/libmpc832xemds.o: In function
> board_early_init_r':
> /home/r1aaha/git/u-boot/board/freescale/mpc832xemds/mpc832xemds.c:90:
> undefined reference to `pib_init'
> make: *** [u-boot] Error 1
>
> So,
>
> Acked-by: Kim Phillips <kim.phillips@freescale.com>
Applied, thanks.
Cheers
Detlev
--
Science is a way of thinking
much more than it is a body of knowledge.
-- Carl Sagan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
prev parent reply other threads:[~2012-08-17 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 0:50 [U-Boot] [PATCH] Makefile: fix HAVE_VENDOR_COMMON_LIB Scott Wood
2012-08-14 11:44 ` [U-Boot] [PATCH v2] " Daniel Schwierzeck
2012-08-15 1:12 ` Kim Phillips
2012-08-17 16:18 ` Detlev Zundel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ipcha3wa.fsf@lamuella.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.