From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A29A436493E for ; Mon, 18 May 2026 13:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779112620; cv=none; b=A2rU6JQ37PWrMDVsP6KlXvYJF2pfXAWIdMQqDKtgs051KNqVsirX1BR2FwjsONONufH7O6C9Egxs96M5K7QecYCHMDY34V5jEpOyvaN7RYsbnDNhVeCXRlZU90I0R7gJ2aOSVZOHz0rW0rLZIkWn6SG2NhY8f3IoFlt3o+fMIX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779112620; c=relaxed/simple; bh=/W9pD0HKew0iA/EeshWUTfYiNJ1bfIbcDrX808DQYo4=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References: MIME-Version:Content-Type; b=fgdbpIgEhW6BiHxAV3bcMFtvNv40Lg7i8D5u8XpLkWtJpt/AlGL5iEmtXhoIEm72hx13BMzp63uJCZIigDaFmo4wYe/uUQKXU8VXYHADh5c8cwNO7e4quUtZovvbvOOS9lTphimNY6sEKnBjYB7RtP2+hMndwFCI18dVETp4K1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pX2ThYEd; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pX2ThYEd" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso31643375e9.1 for ; Mon, 18 May 2026 06:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779112617; x=1779717417; darn=vger.kernel.org; h=mime-version:user-agent:references:message-id:date:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VJrhjTPuMfvEFTG0qlotlJlzRB+WiMenwkw8JGsUgUg=; b=pX2ThYEdfnjx+HkP8UHQXbXtLiuOll75uvg/WNiTKG2iP6G7oy7SPYZEcyPItEHn57 l39yi2yqCGJszSmV1oQnep5uuEE3G50kYN4rsUx8idLBYI+UAauFPLRhGH0WJvax26Qo 3wJApu8VGbpreLND+S/CeiJZFF53P1XeQy5ezSnpQYhpxNppeLfEAPEPRfSiEAUbNuCw 2lEUpHcV4ii7lbyT5h+aSknMrcAyKH/yOkabceiWyCrGIZKk1MOpkvRZpelh5Ph8PjoI BS8/ezwRH5pSxYRAkNnb+sr2uibFBcTJxhwNQZV3KAZmmyysPQxIIIvATYVSM0wm7F/W 6Gow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779112617; x=1779717417; h=mime-version:user-agent:references:message-id:date:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VJrhjTPuMfvEFTG0qlotlJlzRB+WiMenwkw8JGsUgUg=; b=OWz/BhpHkR0iad/ixuHA20sdc5bOS7zOzb2r466u1taISzGbebNzogproaQi4/kGcb cerm1EAMoBL2Coq+s7yJKH2ZHitAMK3GxDVS4jJGRWn2bieiNe6q1fbjKC6JJsQHdf+l dpwj7RNyX32EProYAnexiYF6D9cm02QkNOwNngFfrrqqitMOr9TNKmBs3VAlq7pgGcxQ c0eisJE9m8foOpIj2nvzYQeQ79wuM1zEReJ8rFgJG9+w4XoQed133z7EV3JaLM5TRLR6 eJLXZLQ4AUVjeAqa0hNw8xBygw4Uqt6XygJe0UlFnnel+C9iypRb4Wlef2VMU8RGu3iM uzZw== X-Forwarded-Encrypted: i=1; AFNElJ+bhya+OG7UGEHauC6pzDHO41J8jvYvt3IY4MM/Xerlq0L40PNuKsAAtg8krCoyBJALX3yohgJk83kKFzg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+r4Jasg317v3mLm/7yFVLXauvwyMM1F35mLhXHEzvAyC1rKu+ 41MYxuriLEfJ2mkgWdB/XpsxkuHzGJpI0mD0s+IxDNPnOTLFFPBjRqKfqwCCGQ== X-Gm-Gg: Acq92OEs50tSLqJwU5CUjr3cQddO1H6DaFjloYxrfLJvn/0DbXXLU3C5QmVmFuhhNBc wIGJe49lr9Y2Ge0w1BJ4/QUC5dUEsqEaAuWtiBoat1nfORfCyzpU5RtKfGQcmt/MadRvL1wDJ9h zudfugfbU0v7zD4p/Hh498fUlgd9qZAgpMXpVNzQpMPquHbw9r9VEegE7+Nzi/HFWhfrQf1CvAb a6eoCkVngqbMcm2FtQxkW4Mk0Y7H1aMOjgOO/QCE+c0QLFEbqYySiY/StuoeSxsmC7MKwQz/ZAQ 0Sf4Jb6bGZs0L7pa8K1Yt/ozy8dwyNtP1LANcqjH9NeCNgMh7ZG3mIIpctSOWqQz2Hqnv5QppLx LpufNwOfkoPaUFXm/cfY9vttRXQyxkvFOS2iA7GgADO956e5w5hnVnUgZipXJDYtg7PN2E7TpJA WCS/w4koJLUWLhyy4c+TpYm0pf+g== X-Received: by 2002:a05:600c:4e53:b0:490:1640:8269 with SMTP id 5b1f17b1804b1-490164089c7mr32009145e9.18.1779112616709; Mon, 18 May 2026 06:56:56 -0700 (PDT) Received: from imac ([88.97.103.74]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a666fsm36160534f8f.36.2026.05.18.06.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 06:56:56 -0700 (PDT) From: Donald Hunter To: Minxi Hou Cc: netdev@vger.kernel.org, Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Aaron Conole , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] netlink: specs: add OVS packet family specification In-Reply-To: <20260517083358.2088599-2-houminxi@gmail.com> Date: Mon, 18 May 2026 14:52:10 +0100 Message-ID: References: <20260517083358.2088599-1-houminxi@gmail.com> <20260517083358.2088599-2-houminxi@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Minxi Hou writes: > +operations: > + fixed-header: ovs-header > + name-prefix: ovs-packet-cmd- > + list: > + - > + name: miss > + doc: Notify userspace of a flow table miss for a received packet. > + value: 1 > + attribute-set: packet > + event: > + attributes: Instead of repeating the same attributes, this attribute list could be declared with an anchor name such as &event-attrs which could be referenced in the action event. E.g. attributes: &event-attrs > + - packet > + - key > + - userdata > + - actions > + - egress-tun-key > + - mru > + - len > + - hash > + - > + name: action > + doc: Notify userspace as requested by an OVS_ACTION_ATTR_USERSPACE action. > + value: 2 > + attribute-set: packet > + event: > + attributes: attributes: *event-attrs > + - packet > + - key > + - userdata > + - actions > + - egress-tun-key > + - mru > + - len > + - hash Otherwise looks good to me, thanks.