From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com,
nicolas.dichtel@6wind.com, jiri@resnulli.us
Subject: Re: [PATCH net-next] tools: ynl: check for overflow of constructed messages
Date: Wed, 06 Mar 2024 12:31:12 +0000 [thread overview]
Message-ID: <m2jzmfh78v.fsf@gmail.com> (raw)
In-Reply-To: <20240305185000.964773-1-kuba@kernel.org> (Jakub Kicinski's message of "Tue, 5 Mar 2024 10:50:00 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> Donald points out that we don't check for overflows.
> Stash the length of the message on nlmsg_pid (nlmsg_seq would
> do as well). This allows the attribute helpers to remain
> self-contained (no extra arguments). Also let the put
> helpers continue to return nothing. The error is checked
> only in (newly introduced) ynl_msg_end().
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2024-03-07 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 18:50 [PATCH net-next] tools: ynl: check for overflow of constructed messages Jakub Kicinski
2024-03-06 12:31 ` Donald Hunter [this message]
2024-03-07 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2jzmfh78v.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.