From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C272C61DB3 for ; Thu, 12 Jan 2023 18:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240476AbjALSSO (ORCPT ); Thu, 12 Jan 2023 13:18:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240439AbjALSRx (ORCPT ); Thu, 12 Jan 2023 13:17:53 -0500 Received: from smtp4-g21.free.fr (smtp4-g21.free.fr [IPv6:2a01:e0c:1:1599::13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B9D7148A; Thu, 12 Jan 2023 09:47:13 -0800 (PST) Received: from SOPL295.local (unknown [IPv6:2a02:8440:d20f:6de0:6125:d027:2017:9d97]) (Authenticated sender: robert.jarzmik@free.fr) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 0B0F519F59E; Thu, 12 Jan 2023 18:46:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1673545631; bh=KRTPZlKd33p2jA5AfUXMRlfCbedKs4GMu6pgnM4y4Qo=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=LctVqhCykYrI8EvXeqUmUdArGNK/b6sZcJ0gtvgPgfxfckye4plPdcS9NoAVKI7ya +OuDsuuF1zEN2T6xCaKeWWVNYOB0hsY5QWeDseR4wMcwypp6ocReR+eShxR7Tn5nAZ Ufw1bfs5KavS1JtsBALOpAasZvUcCYSVZBr5CRr/gIpWIYd1aDgoywyutwO3O20sH5 /0Nwd4W/cm8SSndULierf0N+0aujwJO0K/OH7wn8eJtMgEnMJffLWHTvy94+7kx3Ie RDFaxi9Ee4NeCA6M3Qk5O/EZiFYqWMlnc3k/vIrnGVtjWeFF1dX/rXG9L9x5gqdwv/ qwjMqYBvKHKJA== References: <20230105134622.254560-1-arnd@kernel.org> <20230105134622.254560-5-arnd@kernel.org> <2d085660-41a2-492c-a343-7df80d510a59@app.fastmail.com> User-agent: mu4e 1.8.11; emacs 28.1 From: Robert Jarzmik To: Arnd Bergmann Cc: Robert Jarzmik , Arnd Bergmann , Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , "Rafael J . Wysocki" , Viresh Kumar , Ulf Hansson , Dominik Brodowski , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, "linux-mmc @ vger . kernel . org" Subject: Re: [PATCH 04/27] ARM: pxa: drop pxa310/pxa320/pxa93x support Date: Thu, 12 Jan 2023 18:37:32 +0100 In-reply-to: <2d085660-41a2-492c-a343-7df80d510a59@app.fastmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org "Arnd Bergmann" writes: > Hi Robert, Hi Arnd, > Thanks for pointing this out, I thought that I had caught > all the missing dependencies ones after you pointed out > the AC97_BUS_NEW that I fixed in patch 14. Sorry I've not seen this one in my previous review. > From what I can tell, commit b5aaaa666a85 ("ARM: pxa: add > Kconfig dependencies for ATAGS based boards"), the > PXA310/PXA320 DT support became dead code because > MACH_PXA3XX_DT only selects CPU_PXA300, so if it worked > before that commit, it now needs CONFIG_UNUSED_BOARD_FILES > and CONFIG_EXPERT as well as enabling one of the legacy > board files with the corresponding chip support. > > If that's all you think is missing, I can add this > trivial patch as well and rework the series to not > drop code that depends on PXA310/PXA320: Yes, that would be great ! > Can you have a look at the other patches to see if there > are more removed drivers or platform bits that are currently > dead code but are actually required? Yes, I've been through your whole serie and that's the last thing I have identified. I've read carefully all the patches now, and the whole serie looks good to me. So with this patch and keeping the clocks and cpufreq parts for pxa3*0, you can add everywhere my : Acked-by: Robert Jarzmik Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09359C61DB3 for ; Thu, 12 Jan 2023 17:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc: To:From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=old1MRxbiXI0Y/zhNJUhDy2qS3xPRZGYofG9rsJE1Vk=; b=TIO27FmXjrNY6+EDui89wnCTPu bCQsHTcqjLP3zA8bA8KHmPcBvAJAHmQQAR5ate7v248Pr6E5q3UojYTkd6GLwFsO58HN1orJBU0Tr Gba7h42Qp3sX/Jm58WZajypoGw0v46yQ3ULPLphkVYHJ/V+TLJlTK6xVgFtdvfBx0XzgnW8hEVcfd e2CksYTPBrZffdVNblN9j+NMekyng4L7XUwfSdRM45XpT7YtK9xCpFSUqQI1ZJaxHr4+FpUnLZOjZ 0BnQOKGToU+llYbcO2LRNKnVxyrzxmkaiApFumb0FZ3UOsVPMGbqQcmEzZwAd66gNeZpx8GFmLatg P2pGGoVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG1fm-00G59i-Iu; Thu, 12 Jan 2023 17:47:30 +0000 Received: from smtp4-g21.free.fr ([212.27.42.4]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG1fd-00G57p-Q6 for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 17:47:24 +0000 Received: from SOPL295.local (unknown [IPv6:2a02:8440:d20f:6de0:6125:d027:2017:9d97]) (Authenticated sender: robert.jarzmik@free.fr) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 0B0F519F59E; Thu, 12 Jan 2023 18:46:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1673545631; bh=KRTPZlKd33p2jA5AfUXMRlfCbedKs4GMu6pgnM4y4Qo=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=LctVqhCykYrI8EvXeqUmUdArGNK/b6sZcJ0gtvgPgfxfckye4plPdcS9NoAVKI7ya +OuDsuuF1zEN2T6xCaKeWWVNYOB0hsY5QWeDseR4wMcwypp6ocReR+eShxR7Tn5nAZ Ufw1bfs5KavS1JtsBALOpAasZvUcCYSVZBr5CRr/gIpWIYd1aDgoywyutwO3O20sH5 /0Nwd4W/cm8SSndULierf0N+0aujwJO0K/OH7wn8eJtMgEnMJffLWHTvy94+7kx3Ie RDFaxi9Ee4NeCA6M3Qk5O/EZiFYqWMlnc3k/vIrnGVtjWeFF1dX/rXG9L9x5gqdwv/ qwjMqYBvKHKJA== References: <20230105134622.254560-1-arnd@kernel.org> <20230105134622.254560-5-arnd@kernel.org> <2d085660-41a2-492c-a343-7df80d510a59@app.fastmail.com> User-agent: mu4e 1.8.11; emacs 28.1 From: Robert Jarzmik To: Arnd Bergmann Cc: Robert Jarzmik , Arnd Bergmann , Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , "Rafael J . Wysocki" , Viresh Kumar , Ulf Hansson , Dominik Brodowski , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, "linux-mmc @ vger . kernel . org" Subject: Re: [PATCH 04/27] ARM: pxa: drop pxa310/pxa320/pxa93x support Date: Thu, 12 Jan 2023 18:37:32 +0100 In-reply-to: <2d085660-41a2-492c-a343-7df80d510a59@app.fastmail.com> Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_094722_327098_92312F43 X-CRM114-Status: GOOD ( 23.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "Arnd Bergmann" writes: > Hi Robert, Hi Arnd, > Thanks for pointing this out, I thought that I had caught > all the missing dependencies ones after you pointed out > the AC97_BUS_NEW that I fixed in patch 14. Sorry I've not seen this one in my previous review. > From what I can tell, commit b5aaaa666a85 ("ARM: pxa: add > Kconfig dependencies for ATAGS based boards"), the > PXA310/PXA320 DT support became dead code because > MACH_PXA3XX_DT only selects CPU_PXA300, so if it worked > before that commit, it now needs CONFIG_UNUSED_BOARD_FILES > and CONFIG_EXPERT as well as enabling one of the legacy > board files with the corresponding chip support. > > If that's all you think is missing, I can add this > trivial patch as well and rework the series to not > drop code that depends on PXA310/PXA320: Yes, that would be great ! > Can you have a look at the other patches to see if there > are more removed drivers or platform bits that are currently > dead code but are actually required? Yes, I've been through your whole serie and that's the last thing I have identified. I've read carefully all the patches now, and the whole serie looks good to me. So with this patch and keeping the clocks and cpufreq parts for pxa3*0, you can add everywhere my : Acked-by: Robert Jarzmik Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel