From: Kevin Hilman <khilman@baylibre.com>
To: Mason <slash.tmp@free.fr>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Sebastian Frias <sf84@laposte.net>
Subject: Re: [PATCH] thermal: tango: add resume support
Date: Mon, 20 Jun 2016 11:17:21 -0700 [thread overview]
Message-ID: <m2k2hjafny.fsf@baylibre.com> (raw)
In-Reply-To: <5768138C.6080206@free.fr> (Mason's message of "Mon, 20 Jun 2016 18:02:20 +0200")
Mason <slash.tmp@free.fr> writes:
> From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Overall looks good, but as I mentioned in the RFC, since you don't have
a ->suspend() method it looks suspicious, so at least the changelog
should describe why you think that doesn't exist. For that matter, the
changelog needs some more description of the patch well. :)
Kevin
next prev parent reply other threads:[~2016-06-20 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 16:02 [PATCH] thermal: tango: add resume support Mason
2016-06-20 18:17 ` Kevin Hilman [this message]
2016-06-21 9:01 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k2hjafny.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=edubezval@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=sf84@laposte.net \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.