From: Andi Kleen <andi@firstfloor.org>
To: "Fenghua Yu" <fenghua.yu@intel.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H Peter Anvin" <hpa@zytor.com>,
"Asit K Mallick" <asit.k.mallick@intel.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86, cpu: Enable/disable SMEP
Date: Wed, 11 May 2011 15:36:30 -0700 [thread overview]
Message-ID: <m2k4dwj24x.fsf@firstfloor.org> (raw)
In-Reply-To: <1305141480-843-4-git-send-email-fenghua.yu@intel.com> (Fenghua Yu's message of "Wed, 11 May 2011 12:18:00 -0700")
"Fenghua Yu" <fenghua.yu@intel.com> writes:
> +static int disable_smep;
If you add a __initdata here the whole thing will completely disappear
after boot.
> @@ -867,6 +886,8 @@ static void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
> /* Init Machine Check Exception if available. */
> mcheck_cpu_init(c);
>
> + setup_smep(c);
My feeling is you're setting this too late. In theory there could be
early overflows. Better use a early_param and set it as early
as possible, directly after the cpuid flags are set up in early
initialization.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-05-11 22:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 19:17 [PATCH 0/3] Enable SMEP CPU Feature Fenghua Yu
2011-05-11 19:17 ` [PATCH 1/3] x86, cpu: Add CPU flags for SMEP Fenghua Yu
2011-05-11 19:17 ` [PATCH 2/3] x86, cpu: Add SMEP CPU feature in CR4 Fenghua Yu
2011-05-11 19:18 ` [PATCH 3/3] x86, cpu: Enable/disable SMEP Fenghua Yu
2011-05-11 22:36 ` Andi Kleen [this message]
2011-05-12 6:06 ` H. Peter Anvin
2011-05-12 6:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2k4dwj24x.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=asit.k.mallick@intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.