From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5AF6D111BB for ; Mon, 4 Nov 2024 08:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pwk6Uc2OREJvGZXQMSTvkbyrCQ02yQz+YhztvTARaZs=; b=ATSpCGe8WUCMLfoQh+V242BsRl ry3tWoujWQY3vdPsPkIEn1J6EdFS/4L2wJBLSVmiBQo4E8vWEqEE7HzNRFZsC6vrhwYA8G+mckJQD eXoSlAqib4IRgJGmHLnJOmMr8qedszxckyjrzBaaimOboP5BiNpD80OegETe++Q76MrXsU8/kg7ZZ Mdw691F0idcWnyLIgwtXUxhIJ9t48/37i+02UMGbizePipPp7XziScAQm/f3JWCh7il0fTXLA/6Fi t4SxhPRNKuQpWq8I4QU48Iy1Uak37MhDelkNjGA7oeJ5NZ9Cyh01airHWV3UXBYEl4G63UikghHBt zt7Ta9Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t7sBV-0000000Cw8E-38D0; Mon, 04 Nov 2024 08:11:37 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t7s8p-0000000Cvmh-2rUq for linux-um@lists.infradead.org; Mon, 04 Nov 2024 08:08:52 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-7eab7622b61so3054280a12.1 for ; Mon, 04 Nov 2024 00:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730707730; x=1731312530; darn=lists.infradead.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=pwk6Uc2OREJvGZXQMSTvkbyrCQ02yQz+YhztvTARaZs=; b=J//LWpf5DTyI3MQGq9ck5kaN9DgH8LohoQs3nQNrbmoSYvYlRYigqywT6TKRSojZis dSlOOD3pR1L2nihWIBE7jM0FGaAP4jeO20hCk9zxs4o/06m1lPykFby4rfSwtB3iFjYU MPoMOVOse8xf8/d9YVI64PSltFqimsTxNv9OL2CP5jmKMOMJPvPZ7g7Ru9hh7CJvekbC GZZMoUR43htaM2z2Sf1CtyNcfGfQDuL9eV2Bzc4r3EORwwkAG4Sh8KsZaWtawhOhxJup BiMNhyDzD++308NjR6WGurfJaIQQ+sDz6TWQfQTM7/p3BBnasZyUSv1talnU9RQCw3tg eaIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730707730; x=1731312530; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pwk6Uc2OREJvGZXQMSTvkbyrCQ02yQz+YhztvTARaZs=; b=S/zuRap9On8XSRopRwxmLKp5gsejv9LPiGvN6yrnSlD6Duklz5kjbOS+BpsXbEoywU yjaBTyvylgrn5/RE/nNRcpA1JwA2rENar+T1SqMxPupVnV7t/7Ui/3uP9SZHIpeDHIZs uC1ikwtH4uNB9e9zTN8l098fgvj8WoB3gfajJR2m9gFFttkYETT2gYXanwtMDVf4KriX U9mV/n0DWousRy7+S8WrJcvkNbaAggPBjQecsEfR+A0rvroCxzen1+AeMfns6DXw2P92 6Gw9valCXc+lPei/IFkV94Rb4xJOpiuSeg489zKnQZjbWEUoDuZDzePw2J06JS1vO5lT wFLw== X-Gm-Message-State: AOJu0YyIefUrTR7CXF3/Q1fjBDc0v2uegdXGCum2cCGmXDT/4DBYht39 pKc1PWJjfefxNqg/lw2QJlHWP5FNnFe9fGGKHGdFZNPUGFSnwYbn X-Google-Smtp-Source: AGHT+IGMbyrOOIqVu6B4xj2l8U0saLEOQniBic/2IUiVSs/MaLWav/wL9KYWFoPkYpYa3Nuwlz0qyA== X-Received: by 2002:a05:6a20:c996:b0:1d8:a29b:8f6f with SMTP id adf61e73a8af0-1d9a83ca155mr42750312637.16.1730707730032; Mon, 04 Nov 2024 00:08:50 -0800 (PST) Received: from mars.local.gmail.com (sp1-75-153-147.msc.spmode.ne.jp. [1.75.153.147]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ee452a995bsm6519792a12.21.2024.11.04.00.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 00:08:49 -0800 (PST) Date: Mon, 04 Nov 2024 17:08:45 +0900 Message-ID: From: Hajime Tazaki To: benjamin@sipsolutions.net Cc: linux-um@lists.infradead.org, benjamin.berg@intel.com Subject: Re: [PATCH] um: move thread info into task In-Reply-To: <20241103150534.1368018-1-benjamin@sipsolutions.net> References: <20241103150534.1368018-1-benjamin@sipsolutions.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241104_000851_744256_3CC145B1 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org Hello, this is a great clean up I think. I've also applied my tentative nommu patch and works fine with minor modifications. On Mon, 04 Nov 2024 00:05:34 +0900, Benjamin Berg wrote: > diff --git a/arch/um/include/asm/current.h b/arch/um/include/asm/current.h > new file mode 100644 > index 000000000000..93ee89e56372 > --- /dev/null > +++ b/arch/um/include/asm/current.h > @@ -0,0 +1,24 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __ASM_CURRENT_H > +#define __ASM_CURRENT_H > + > +#include > + > +#ifndef __ASSEMBLY__ > + > +#include with this include, I guess is now in a circular dependency. after only applying this patch onto uml/next, and make mrproper ARCH=um, I cannot build UML kernel with defconfig. > diff --git a/arch/um/os-Linux/signal.c b/arch/um/os-Linux/signal.c > index 1978eaa557e9..87d31a0672c0 100644 > --- a/arch/um/os-Linux/signal.c > +++ b/arch/um/os-Linux/signal.c > @@ -186,47 +186,14 @@ static void (*handlers[_NSIG])(int sig, struct siginfo *si, mcontext_t *mc) = { > [SIGUSR1] = sigusr1_handler, > }; > > +extern char cpu0_irqstack[]; > + maybe this line isn't needed ? -- Hajime