Re: [PATCH 0/4] Clean up code and fix coverity bugs in util/grub-module-verifierXX.c

[Darren Kenny <darren.kenny@oracle.com>]

Hi Alec,

These look good to me, thanks for handling the Coverity issues here.

For the series:

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>

Thanks,

Darren.

On Wednesday, 2022-02-02 at 19:26:56 -05, Alec Brown wrote:
> Coverity identified several untrusted loop bounds in
> util/grub-module-verifierXX.c. This patch series addresses these bugs, cleans up
> lengthy equations, and makes checks to values based on the elf manual page.
>
> The Coverity Bugs being addressed are:
> CID 314021
> CID 314027
> CID 314033
>
> Alec Brown (4):
>       util/grub-module-verifierXX.c: Add function to calculate section headers
>       util/grub-module-verifierXX.c: Validate number of elf section header table entries
>       util/grub-module-verifierXX.c: Validate elf section header table index for section name string table
>       util/grub-module-verifierXX.c: Add module_size parameter to functions for sanity checking
>
>  util/grub-module-verifierXX.c | 124 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------
>  1 file changed, 93 insertions(+), 31 deletions(-)