From: Andreas Schwab <schwab@linux-m68k.org>
To: Joachim Eastwood <manabian@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mandeep Singh Baines <msb@chromium.org>,
linux-kernel@vger.kernel.org,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Nicolas Pitre <nico@cam.org>,
Herbert Xu <herbert@gondor.hengli.com.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux@arm.linux.org.uk
Subject: Re: [PATCH] lib/sha1: use the git implementation of SHA-1
Date: Sun, 07 Aug 2011 21:47:58 +0200 [thread overview]
Message-ID: <m2liv5ovf5.fsf@igel.home> (raw)
In-Reply-To: <CAGhQ9VwgpPv=z3TmODKwaXSneTaCrsj4cTpLEVXJ1aATiGZLrg@mail.gmail.com> (Joachim Eastwood's message of "Sun, 7 Aug 2011 20:57:36 +0200")
Joachim Eastwood <manabian@gmail.com> writes:
> On Sun, Aug 7, 2011 at 8:38 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> There aren't many users of that define, could you just turn it back to the proper 16, and then try changing it to 80 in each place that uses it?
>>
>> That way we'd see exactly *which* use is the buggy one..
>
> Its drivers/char/random.c.
ARM has its own implementation of sha_transform in arch/arm/lib/sha1.S,
which assumes SHA_WORKSPACE_WORDS is 80.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-08-07 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 1:46 [PATCH] lib/sha1: use the git implementation of SHA-1 Mandeep Singh Baines
2011-08-07 11:54 ` Joachim Eastwood
2011-08-07 16:52 ` Linus Torvalds
2011-08-07 17:36 ` Joachim Eastwood
2011-08-07 17:44 ` Linus Torvalds
2011-08-07 18:08 ` Joachim Eastwood
2011-08-07 18:38 ` Linus Torvalds
2011-08-07 18:57 ` Joachim Eastwood
2011-08-07 19:47 ` Andreas Schwab [this message]
2011-08-07 20:17 ` Linus Torvalds
2011-08-07 20:48 ` Joachim Eastwood
2011-08-07 21:06 ` Linus Torvalds
2011-08-07 21:29 ` [PATCH] treewide: Remove direct uses of SHA_WORKSPACE_WORDS Joe Perches
2011-08-07 21:41 ` Linus Torvalds
2011-08-08 1:25 ` [PATCH] lib/sha1: use the git implementation of SHA-1 Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2liv5ovf5.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=manabian@gmail.com \
--cc=msb@chromium.org \
--cc=nico@cam.org \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.