From: Darren Kenny <darren.kenny@oracle.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>, Alexander Bulekov <alxndr@bu.edu>,
Bandan Das <bsd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] fuzz: ignore address_space_map is_write flag
Date: Wed, 20 Jan 2021 10:11:02 +0000 [thread overview]
Message-ID: <m2mtx3dikp.fsf@oracle.com> (raw)
In-Reply-To: <20210120060255.558535-1-alxndr@bu.edu>
On Wednesday, 2021-01-20 at 01:02:55 -05, Alexander Bulekov wrote:
> We passed an is_write flag to the fuzz_dma_read_cb function to
> differentiate between the mapped DMA regions that need to be populated
> with fuzzed data, and those that don't. We simply passed through the
> address_space_map is_write parameter. The goal was to cut down on
> unnecessarily populating mapped DMA regions, when they are not read
> from.
>
> Unfortunately, nothing precludes code from reading from regions mapped
> with is_write=true. For example, see:
> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg04729.html
>
> This patch removes the is_write parameter to fuzz_dma_read_cb. As a
> result, we will fill all mapped DMA regions with fuzzed data, ignoring
> the specified transfer direction.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
prev parent reply other threads:[~2021-01-20 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 6:02 [PATCH] fuzz: ignore address_space_map is_write flag Alexander Bulekov
2021-01-20 10:11 ` Darren Kenny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mtx3dikp.fsf@oracle.com \
--to=darren.kenny@oracle.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.