From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Mon, 31 Oct 2016 14:46:17 -0600 Subject: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes In-Reply-To: <12222113.L5elJM2tqN@avalon> (Laurent Pinchart's message of "Mon, 31 Oct 2016 22:22:54 +0200") References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> <12222113.L5elJM2tqN@avalon> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Laurent Pinchart writes: > Hi Bartosz, > > Thank you for the patch. > > On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote: >> Enable the MSTPRI configuration and DDR2/mDDR memory controller >> nodes on da850-lcdk. This is needed in order to adjust the memory >> throughput constraints for better tilcdc support. > > Is there a reason not to enable these unconditionally in da850.dtsi (or rather > not disabling them) instead of handling it per board ? Right. They should be enabled by default in DT. The drivers already have board-specific compatible checks. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Date: Mon, 31 Oct 2016 14:46:17 -0600 Message-ID: References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> <12222113.L5elJM2tqN@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <12222113.L5elJM2tqN@avalon> (Laurent Pinchart's message of "Mon, 31 Oct 2016 22:22:54 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Mark Rutland , linux-devicetree , Tomi Valkeinen , Michael Turquette , Sekhar Nori , Russell King , linux-drm , LKML , Peter Ujfalusi , Bartosz Golaszewski , Rob Herring , Jyri Sarha , Frank Rowand , arm-soc List-Id: devicetree@vger.kernel.org TGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPiB3cml0 ZXM6Cgo+IEhpIEJhcnRvc3osCj4KPiBUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KPgo+IE9uIE1v bmRheSAzMSBPY3QgMjAxNiAxNTo0NTozNyBCYXJ0b3N6IEdvbGFzemV3c2tpIHdyb3RlOgo+PiBF bmFibGUgdGhlIE1TVFBSSSBjb25maWd1cmF0aW9uIGFuZCBERFIyL21ERFIgbWVtb3J5IGNvbnRy b2xsZXIKPj4gbm9kZXMgb24gZGE4NTAtbGNkay4gVGhpcyBpcyBuZWVkZWQgaW4gb3JkZXIgdG8g YWRqdXN0IHRoZSBtZW1vcnkKPj4gdGhyb3VnaHB1dCBjb25zdHJhaW50cyBmb3IgYmV0dGVyIHRp bGNkYyBzdXBwb3J0Lgo+Cj4gSXMgdGhlcmUgYSByZWFzb24gbm90IHRvIGVuYWJsZSB0aGVzZSB1 bmNvbmRpdGlvbmFsbHkgaW4gZGE4NTAuZHRzaSAob3IgcmF0aGVyIAo+IG5vdCBkaXNhYmxpbmcg dGhlbSkgaW5zdGVhZCBvZiBoYW5kbGluZyBpdCBwZXIgYm9hcmQgPwoKUmlnaHQuICBUaGV5IHNo b3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQgaW4gRFQuICBUaGUgZHJpdmVycyBhbHJlYWR5Cmhh dmUgYm9hcmQtc3BlY2lmaWMgY29tcGF0aWJsZSBjaGVja3MuCgpLZXZpbgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034244AbcJaUq0 (ORCPT ); Mon, 31 Oct 2016 16:46:26 -0400 Received: from mail-yw0-f172.google.com ([209.85.161.172]:33861 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S946721AbcJaUqV (ORCPT ); Mon, 31 Oct 2016 16:46:21 -0400 From: Kevin Hilman To: Laurent Pinchart Cc: Bartosz Golaszewski , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , Tomi Valkeinen , David Airlie Subject: Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes Organization: BayLibre References: <1477925138-23457-1-git-send-email-bgolaszewski@baylibre.com> <1477925138-23457-5-git-send-email-bgolaszewski@baylibre.com> <12222113.L5elJM2tqN@avalon> Date: Mon, 31 Oct 2016 14:46:17 -0600 In-Reply-To: <12222113.L5elJM2tqN@avalon> (Laurent Pinchart's message of "Mon, 31 Oct 2016 22:22:54 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Laurent Pinchart writes: > Hi Bartosz, > > Thank you for the patch. > > On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote: >> Enable the MSTPRI configuration and DDR2/mDDR memory controller >> nodes on da850-lcdk. This is needed in order to adjust the memory >> throughput constraints for better tilcdc support. > > Is there a reason not to enable these unconditionally in da850.dtsi (or rather > not disabling them) instead of handling it per board ? Right. They should be enabled by default in DT. The drivers already have board-specific compatible checks. Kevin