From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7003C9ED5 for ; Wed, 15 Jul 2026 11:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784114214; cv=none; b=Uvy+GKzMt9+zsR++FP9i9+oj4IYRQNUU54gFIVc8vPouG5yligjTytX+WGTQPW/2fDq9sD/V3HW0aDlvVKHd057w0sfuhMqQTaSWtYJYh0mspNMb3GLW4jYZ1Bl493k6J90iaGlq/p88tZ/gK05QxN/UQntm2jKDYPwR8SFhIzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784114214; c=relaxed/simple; bh=HZpP+eYnvqgbZe598aJSUkGMNUbOrLPlP4WxoEV6Cic=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=flS1dv10EKNzj+g+w5ESi1dVw2+HXwOYv5ja5a7rdb0P1ch/fpGjBdRgU3bom956iXNWT1OuPALLBkLreBnmPTp1posS2c5hTQ2kK42vo4fd72EZV3Ex3sQZiBXy9WVgmwc3nb3ypYlLQj9LtC66Lj63a7TsDFtX3lN8saeIV1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FMiev6p9; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FMiev6p9" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4629051c9d1so1259104f8f.2 for ; Wed, 15 Jul 2026 04:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784114211; x=1784719011; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=i/YnbegFnz1wwTJlvFDY2bFOXAZg2zEqKBOBmaLrjis=; b=FMiev6p985OY0NvfO98zCfNZ8gOF+/vn5ZB1PQ4Ea1N1QnhKR+L74Xueimeuvo0hAL nEiCHoG/u4O/FZF4nA732Jl5uWQw+Hp58E57Z4s4/RkSJVwXWeb+WrTca9+anlA0dyzw mRT3zeqeGQGhcAcvvyAMYgtZsIsoc4hn15XIhDu8ezGesU486yc9Y0f6jt55w6lqdY0q lOiGKR8S+AYNMlGCiTwsH4LS3DoIMHbZp0ryhLspYysPruqNo0yjmW6BStMcnjHpShNc 38vMaKi13V+p2QO6PWdGpb8V/OJ/mXf7sqH8iUxhNMmiBYkpuGVu9m7YtPMJ7CsV6x3H yXIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784114211; x=1784719011; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=i/YnbegFnz1wwTJlvFDY2bFOXAZg2zEqKBOBmaLrjis=; b=MVBeg+IOX7GWJEL0VTzNQmUVY7M4YvFwybA+JicS4I5+a8yNfoQFGvM9dhJpmnEyaT 7rmCqtSY0vPsYGcqDdqrfxPdjP1Ulu7b5RpHrai8jjqKxW6RkgB92P4fhMNoxck5jXe/ mk84cBooO47eImUW3lBfgXZL+Qx9S/TruyW3N9rszbh0eWpBeTrM75/+CMJsZRzVEwqZ zbBOq4bct7gTlxk13qlDEB1babA/a1RezJ5FvlF/e9k/oK5bWqhotkfN6L956uvXK55b BQMZVeLSpzTaefCXVUsOPgUl5j74Ap2p3/2L5Q3ey3mkSR3LINtdpzUhqwa2EtDQLlnN 4ULg== X-Forwarded-Encrypted: i=1; AHgh+RpF2k9PIdKQSid2Dgx9uOU/W+eNiKJj8XdJoBttDcRXtvjf4uwsmFG53OyTnsZrFVd8IBPLY5LJwjGOa/k=@vger.kernel.org X-Gm-Message-State: AOJu0YzvDrjHaR0xzF4hExYqhVMljr0CUvADEIF764tHK8pxYcTRLYBH aBLTyTqtcF7iZvHF7EUhjByWEAlXGG4hpdynl7cnDEXAHitdvyS4qO83QtceAQ== X-Gm-Gg: AfdE7cn3duCREmswTY6GWd+32uvaZNxEJTP2Sy5om2CP0iEACvzjZH3OKG339cHW7kR udVX8fRirZw145Ue7RHYaEq1qVsX7unx4SJ6413RnEZUuoV6D73Ef96iCt2bGJMtYWm1FqoOyh/ R/veARp41vPxmvwbbWkW9TntADeMhGGrKAJmOOs91CGnyEqJ99N/IDXhxJZBo2WXeb/AC+4i9n+ 3cmtjunxPOxJwxUOGxgz8F4lJ6LcaqG1BFNfrD8JPEw0Cnv6temI5oU4Qnfkh3lCy3+/7UDMsi+ XKM8DacaGkGYRu4uaXXU1S8UA6ejYiKE7eyk4ydO4rKQpihtZmSycnJ8cR4moUwK+sIaq+0pTfs iiMIlUyXAblwRikqUqDYO0TXkuxYpEWf4ObrQNU/abprgs5M3i1XlJj7k+M8+FG98qgdooysySy QeL2Z+2XxFiby+9rAdoM6qsVzyjyTb1PD3uILB43kCkSD/bM8tvecUcjpGjGfQGqbfLA== X-Received: by 2002:a05:6000:2508:b0:473:d65d:49c1 with SMTP id ffacd0b85a97d-47f2dcd739amr20287206f8f.32.1784114211112; Wed, 15 Jul 2026 04:16:51 -0700 (PDT) Received: from Abds-MacBook-Air.local ([2a02:3030:66c:7341:15aa:e312:84c7:17f2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464a973fsm16486017f8f.17.2026.07.15.04.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 04:16:50 -0700 (PDT) From: Abd-Alrhman Masalkhi To: John Garry , song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, axboe@kernel.dk, martin.petersen@oracle.com, linux-kernel@vger.kernel.org Cc: linux-raid@vger.kernel.org Subject: Re: [PATCH v4 3/7] md/raid10: consistently fail atomic writes that require splitting In-Reply-To: References: <20260710101521.1714-1-abd.masalkhi@gmail.com> <20260710101521.1714-4-abd.masalkhi@gmail.com> <33aca226-f744-45e0-a137-1f85ab146e02@oracle.com> Date: Wed, 15 Jul 2026 13:16:45 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi John, On Wed, Jul 15, 2026 at 11:49 +0100, John Garry wrote: > On 15/07/2026 11:05, Abd-Alrhman Masalkhi wrote: >> On Wed, Jul 15, 2026 at 10:25 +0100, John Garry wrote: >>> On 10/07/2026 11:15, Abd-Alrhman Masalkhi wrote: >>>> RAID10 currently handles one badblock path explicitly by failing atomic >>>> writes with EIO. However, another badblock path can also reduce the >>>> writable range and force the bio through bio_submit_split_bioset(), >>> >>> What is this other badblock path which you are referring to? >>> >> The other path is when the requested write overlaps a bad-block region >> from the beginning, but the intended write extends beyond the bad-block >> region. In that case, the current code silently reduces max_sectors. >> As a result, we end up calling bio_submit_split_bioset(), which >> completes the bio with -EINVAL rather than -EIO. This is the same issue >> that existed in raid1 and was fixed by patch 2. > > OK, it would be nice to add a concise version of that info to the commit > log. > Thanks. I'll update the commit log accordingly and send v5. > Reviewed-by: John Garry -- Best Regards, Abd-Alrhman