From: Donald Hunter <donald.hunter@gmail.com>
To: Petr Machata <petrm@nvidia.com>
Cc: <francois.michel@uclouvain.be>, <netdev@vger.kernel.org>,
<stephen@networkplumber.org>, <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string
Date: Thu, 31 Aug 2023 10:05:31 +0100 [thread overview]
Message-ID: <m2pm33eg4k.fsf@gmail.com> (raw)
In-Reply-To: <87ledssftn.fsf@nvidia.com> (Petr Machata's message of "Wed, 30 Aug 2023 17:32:01 +0200")
Petr Machata <petrm@nvidia.com> writes:
> francois.michel@uclouvain.be writes:
>
>> From: François Michel <francois.michel@uclouvain.be>
>>
>> Signed-off-by: François Michel <francois.michel@uclouvain.be>
>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
>
> That said...
>
>> " [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>> " [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>
> ... and sorry for piling on like this, but since we are in the domain of
> fixing netem typos, if you would also fix the missing brackets on these
> two lines, that would be awesome.
The tc-netem(8) man page suggests (and usage confirms) that P14 is also
an optional parameter so it should be bracketed as well.
https://www.man7.org/linux/man-pages/man8/tc-netem.8.html
next prev parent reply other threads:[~2023-08-31 9:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 15:05 [PATCH iproute2-next 0/1] tc: fix typo in netem's usage string francois.michel
2023-08-30 15:05 ` [PATCH iproute2-next 1/1] " francois.michel
2023-08-30 15:32 ` Petr Machata
2023-08-30 19:00 ` David Ahern
2023-08-31 9:05 ` Donald Hunter [this message]
2023-08-31 9:12 ` François Michel
2023-08-30 19:00 ` [PATCH iproute2-next 0/1] " David Ahern
2023-08-30 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pm33eg4k.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=francois.michel@uclouvain.be \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.