From: Andreas Schwab <schwab@linux-m68k.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Maris Paupe <marisp@mt.lv>, <epasheva@sierrawireless.com>,
<rfiler@sierrawireless.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] fix sierra_net endianess bug
Date: Wed, 14 Mar 2012 22:10:35 +0100 [thread overview]
Message-ID: <m2pqce51o4.fsf@igel.home> (raw)
In-Reply-To: <1331753062.2564.6.camel@bwh-desktop.uk.solarflarecom.com> (Ben Hutchings's message of "Wed, 14 Mar 2012 19:24:22 +0000")
Ben Hutchings <bhutchings@solarflare.com> writes:
> On Wed, 2012-03-14 at 16:26 +0100, Andreas Schwab wrote:
>> Maris Paupe <marisp@mt.lv> writes:
>>
>> > I have found that sierra_net does not work properly on big-endian
>> > systems, it works if bytes are flipped in this particular location.
>>
>> That should probably be fixed in sierra_net_get_fw_attr (and the author
>> of sierra_net_get_fw_attr should be hit with a cluestick to not use
>> kmalloc for allocating a single u16).
>
> You cannot use stack buffers for DMA, which includes all USB I/O.
Ok, sorry, I didn't know that.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2012-03-14 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 14:09 [PATCH] fix sierra_net endianess bug Maris Paupe
2012-03-14 15:26 ` Andreas Schwab
2012-03-14 19:24 ` Ben Hutchings
2012-03-14 21:10 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pqce51o4.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=bhutchings@solarflare.com \
--cc=epasheva@sierrawireless.com \
--cc=marisp@mt.lv \
--cc=netdev@vger.kernel.org \
--cc=rfiler@sierrawireless.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.