From: Andreas Schwab <schwab@linux-m68k.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jim Meyering <jim@meyering.net>,
Fredrik Gustafsson <iveqy@iveqy.com>
Subject: Re: [PATCH 3/3] grep: get rid of useless x < 0 comparison on an enum member
Date: Sun, 06 Nov 2011 16:03:23 +0100 [thread overview]
Message-ID: <m2pqh5nvic.fsf@igel.home> (raw)
In-Reply-To: <1320581184-4557-4-git-send-email-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sun, 6 Nov 2011 13:06:24 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Remove an "p->field < 0" comparison in grep.c that'll always be
> false. In this case "p" is a "grep_pat" where "field" is defined as:
>
> enum grep_header_field field;
>
> And grep_header_field is in turn defined as:
>
> enum grep_header_field {
> GREP_HEADER_AUTHOR = 0,
> GREP_HEADER_COMMITTER
> };
>
> Meaning that this comparison will always be false.
The underlying integer type is implementation-defined, and can be any
signed or unsigned integer type that can represent all enumerations.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-11-06 15:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 12:06 [PATCH 0/3] Fix code issues spotted by clang Ævar Arnfjörð Bjarmason
2011-11-06 12:06 ` [PATCH 1/3] apply: get rid of useless x < 0 comparison on a size_t type Ævar Arnfjörð Bjarmason
2011-11-06 18:35 ` Junio C Hamano
2011-11-07 19:09 ` Giuseppe Bilotta
2011-11-06 12:06 ` [PATCH 2/3] diff/apply: cast variable in call to free() Ævar Arnfjörð Bjarmason
2011-11-06 12:06 ` [PATCH 3/3] grep: get rid of useless x < 0 comparison on an enum member Ævar Arnfjörð Bjarmason
2011-11-06 15:03 ` Andreas Schwab [this message]
2011-11-07 12:42 ` Ævar Arnfjörð Bjarmason
2011-11-07 13:12 ` Andreas Schwab
2011-11-07 16:38 ` Jeff King
2011-11-07 18:24 ` Andreas Schwab
2011-11-07 18:34 ` Jeff King
2011-11-07 18:55 ` Jeff King
2011-11-07 19:06 ` Ævar Arnfjörð Bjarmason
2011-11-07 20:13 ` Andreas Schwab
2011-11-07 19:49 ` Jonathan Nieder
2011-11-07 21:18 ` Junio C Hamano
2011-11-07 21:32 ` Jonathan Nieder
2011-11-07 21:48 ` Junio C Hamano
2011-11-07 22:21 ` Jonathan Nieder
2011-11-06 12:33 ` [PATCH 0/3] Fix code issues spotted by clang Ævar Arnfjörð Bjarmason
2011-11-08 16:05 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pqh5nvic.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.