From: Fiona Behrens <me@kloenk.dev>
To: Benno Lossin <benno.lossin@proton.me>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/22] rust: pin-init: move the default error behavior of `try_[pin_]init`
Date: Wed, 05 Mar 2025 10:21:23 +0100 [thread overview]
Message-ID: <m2r03bhlyk.fsf@kloenk.dev> (raw)
In-Reply-To: <20250304225245.2033120-8-benno.lossin@proton.me> (Benno Lossin's message of "Tue, 04 Mar 2025 22:54:07 +0000")
Benno Lossin <benno.lossin@proton.me> writes:
> Move the ability to just write `try_pin_init!(Foo { a <- a_init })`
> (note the missing `? Error` at the end) into the kernel crate.
> Remove this notation from the pin-init crate, since the default when no
> error is specified is the kernel-internal `Error` type. Instead add two
> macros in the kernel crate that serve this default and are used instead
> of the ones from `pin-init`.
>
> This is done, because the `Error` type that is used as the default is
> from the kernel crate and it thus prevents making the pin-init crate
> standalone.
>
> In order to not cause a build error due to a name overlap, the macros in
> the pin-init crate are renamed, but this change is reverted in a future
> commit when it is a standalone crate.
>
> Signed-off-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Fiona Behrens <me@kloenk.dev>
next prev parent reply other threads:[~2025-03-05 9:21 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <xn5HRPkxO91lsoIUAwMnnAvQRCAgmw6nzTZX2DsODS0viAvz_g6B8l3dpYNtcL2jBXySi0DQrVi04b6MY8GbMw==@protonmail.internalid>
2025-03-04 22:52 ` [PATCH 00/22] make pin-init into a standalone crate Benno Lossin
2025-03-04 22:53 ` [PATCH 01/22] rust: init: disable doctests Benno Lossin
2025-03-05 8:51 ` Andreas Hindborg
2025-03-05 12:53 ` Benno Lossin
2025-03-05 13:00 ` Miguel Ojeda
2025-03-05 14:09 ` Andreas Hindborg
2025-03-05 14:31 ` Benno Lossin
2025-03-05 9:17 ` Fiona Behrens
2025-03-04 22:53 ` [PATCH 02/22] rust: move pin-init API into its own directory Benno Lossin
2025-03-05 9:03 ` Andreas Hindborg
2025-03-05 9:17 ` Fiona Behrens
2025-03-04 22:53 ` [PATCH 03/22] rust: add extensions to the pin-init crate and move relevant documentation there Benno Lossin
2025-03-05 9:11 ` Andreas Hindborg
2025-03-05 11:03 ` Benno Lossin
2025-03-05 9:17 ` Fiona Behrens
2025-03-04 22:53 ` [PATCH 04/22] rust: pin-init: move proc-macro documentation into pin-init crate Benno Lossin
2025-03-05 9:18 ` Fiona Behrens
2025-03-05 9:34 ` Andreas Hindborg
2025-03-05 11:05 ` Benno Lossin
2025-03-04 22:53 ` [PATCH 05/22] rust: pin-init: change examples to the user-space version Benno Lossin
2025-03-05 9:19 ` Fiona Behrens
2025-03-05 10:06 ` Andreas Hindborg
2025-03-04 22:53 ` [PATCH 06/22] rust: pin-init: call `try_[pin_]init!` from `[pin_]init!` instead of `__init_internal!` Benno Lossin
2025-03-05 9:19 ` Fiona Behrens
2025-03-05 10:12 ` Andreas Hindborg
2025-03-04 22:54 ` [PATCH 07/22] rust: pin-init: move the default error behavior of `try_[pin_]init` Benno Lossin
2025-03-05 9:21 ` Fiona Behrens [this message]
2025-03-05 10:29 ` Andreas Hindborg
2025-03-05 10:47 ` Benno Lossin
2025-03-04 22:54 ` [PATCH 08/22] rust: pin-init: move `InPlaceInit` and impls of `InPlaceWrite` into the kernel crate Benno Lossin
2025-03-05 9:23 ` Fiona Behrens
2025-03-05 11:18 ` Andreas Hindborg
2025-03-05 12:06 ` Benno Lossin
2025-03-05 12:28 ` Andreas Hindborg
2025-03-05 12:37 ` Benno Lossin
2025-03-04 22:54 ` [PATCH 09/22] rust: pin-init: move impl `Zeroable` for `Opaque` and `Option<KBox<T>>` " Benno Lossin
2025-03-05 9:24 ` Fiona Behrens
2025-03-05 11:26 ` Andreas Hindborg
2025-03-05 12:05 ` Benno Lossin
2025-03-05 12:11 ` Alice Ryhl
2025-03-05 12:17 ` Benno Lossin
2025-03-05 12:49 ` Alice Ryhl
2025-03-05 12:51 ` Benno Lossin
2025-03-04 22:54 ` [PATCH 10/22] rust: add `ZeroableOption` and implement it instead of `Zeroable` for `Option<Box<T, A>>` Benno Lossin
2025-03-05 9:25 ` Fiona Behrens
2025-03-05 11:30 ` Andreas Hindborg
2025-03-04 22:54 ` [PATCH 11/22] rust: pin-init: fix documentation links Benno Lossin
2025-03-05 9:26 ` Fiona Behrens
2025-03-05 11:37 ` Andreas Hindborg
2025-03-05 11:49 ` Benno Lossin
2025-03-04 22:54 ` [PATCH 12/22] rust: pin-init: remove kernel-crate dependency Benno Lossin
2025-03-05 9:27 ` Fiona Behrens
2025-03-05 11:49 ` Andreas Hindborg
2025-03-05 12:00 ` Benno Lossin
2025-03-05 12:27 ` Andreas Hindborg
2025-03-04 22:55 ` [PATCH 13/22] rust: pin-init: change the way the `paste!` macro is called Benno Lossin
2025-03-05 9:28 ` Fiona Behrens
2025-03-05 11:52 ` Andreas Hindborg
2025-03-04 22:55 ` [PATCH 14/22] rust: add pin-init crate build infrastructure Benno Lossin
2025-03-05 11:59 ` Andreas Hindborg
2025-03-05 12:10 ` Benno Lossin
2025-03-05 12:31 ` Andreas Hindborg
2025-03-05 12:50 ` Miguel Ojeda
2025-03-05 13:00 ` Benno Lossin
2025-03-05 14:19 ` Andreas Hindborg
2025-03-05 14:34 ` Benno Lossin
2025-03-05 12:47 ` Miguel Ojeda
2025-03-04 22:55 ` [PATCH 15/22] rust: make pin-init its own crate Benno Lossin
2025-03-05 9:29 ` Fiona Behrens
2025-03-05 12:12 ` Andreas Hindborg
2025-03-05 13:40 ` Benno Lossin
2025-03-05 14:20 ` Andreas Hindborg
2025-03-04 22:55 ` [PATCH 16/22] rust: pin-init: add `std` and `alloc` support from the user-space version Benno Lossin
2025-03-05 9:32 ` Fiona Behrens
2025-03-05 12:22 ` Andreas Hindborg
2025-03-05 13:55 ` Benno Lossin
2025-03-05 14:29 ` Andreas Hindborg
2025-03-05 15:05 ` Benno Lossin
2025-03-05 17:27 ` Andreas Hindborg
2025-03-04 22:55 ` [PATCH 17/22] rust: pin-init: synchronize documentation with " Benno Lossin
2025-03-05 9:33 ` Fiona Behrens
2025-03-05 12:52 ` Andreas Hindborg
2025-03-04 22:55 ` [PATCH 18/22] rust: pin-init: internal: synchronize with " Benno Lossin
2025-03-05 12:56 ` Andreas Hindborg
2025-03-04 22:56 ` [PATCH 19/22] rust: pin-init: miscellaneous synchronization with the " Benno Lossin
2025-03-05 12:57 ` Andreas Hindborg
2025-03-04 22:56 ` [PATCH 20/22] rust: pin-init: add miscellaneous files from " Benno Lossin
2025-03-05 9:35 ` Fiona Behrens
2025-03-05 13:04 ` Andreas Hindborg
2025-03-05 13:37 ` Miguel Ojeda
2025-03-05 13:58 ` Benno Lossin
2025-03-04 22:56 ` [PATCH 21/22] rust: pin-init: re-enable doctests Benno Lossin
2025-03-05 9:35 ` Fiona Behrens
2025-03-05 13:05 ` Andreas Hindborg
2025-03-04 22:56 ` [PATCH 22/22] MAINTAINERS: add entry for the `pin-init` crate Benno Lossin
2025-03-05 0:17 ` Jarkko Sakkinen
2025-03-05 0:43 ` Benno Lossin
2025-03-05 5:14 ` Jarkko Sakkinen
2025-03-04 23:12 ` [PATCH 00/22] make pin-init into a standalone crate Benno Lossin
2025-03-05 13:56 ` Andreas Hindborg
2025-03-05 14:03 ` Benno Lossin
2025-03-05 14:36 ` Andreas Hindborg
2025-03-05 14:47 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r03bhlyk.fsf@kloenk.dev \
--to=me@kloenk.dev \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.