From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82919D0C60B for ; Fri, 25 Oct 2024 13:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g3HHwVODzuEE9PRV9lAGZU4zpYPa+SZB9qA0gLY/4to=; b=goxXPDYWzsXFUIi+Kd1M7zOtC+ d0rZGhG57mqHlgNzq+DnfmDf4t9RGRoxGINI7bdDG7h1Fc3d6vdumykizUWex3iRX/DM/xrIWGKE2 SPzF8MRsvn45GV+BBlaFhw8/ysRPuyY9LsbAX+KZTQr+UYbZY7KVD66mFvBIU4vPdLpLK8kXbndFG B55IYl+QuHd8ZX2a2/m3vQAdLXpf4Zmn/UmKKW4AQvLBMkXbvROjvFPNwM+p+rbizLEqcC5vJEPK+ BAd54jxNCYATPtC/dFbBK7JAH0s1F1bbDvrHkotlNK7XFcUVyTWbv4628JG2kiglfPxker1pgNnEE v2xFPcSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t4K5N-00000003lqz-0wWv; Fri, 25 Oct 2024 13:10:37 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t4Jqn-00000003jjQ-2uuB for linux-um@lists.infradead.org; Fri, 25 Oct 2024 12:56:36 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-20ce5e3b116so13510975ad.1 for ; Fri, 25 Oct 2024 05:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729860932; x=1730465732; darn=lists.infradead.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=g3HHwVODzuEE9PRV9lAGZU4zpYPa+SZB9qA0gLY/4to=; b=MldY/51Xdc2avywmdUCd6DtGafHVknTAg81MO1DwfoBQJY7Pe4sIU8PJ6kkQijODlY 9WqAdRklMA4VK4ljStmwSA8RNMxaBgqC6Zq5RyVhPzW86jFGQ7ew6tgarGV2meIp3ecR yKDCWYxtv2VnydpXBX8FCyWifdTzZ39OBsIi0ruxmzeXcHOETu6xnbOTaDqDBGJmf4EF bjR2LYG/BTIviFF6FdP31J9AFmjN9oCnFHVQgTfbmcbyfNEMRRuUi3lDWubvbqDF6unW Wyu6cIgbwciy+0ZajeYG0AMGg1UO5Ebsf6pibSQ5UqMqsJEHEenH8scPimLWpiW9+QDd pe5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729860932; x=1730465732; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g3HHwVODzuEE9PRV9lAGZU4zpYPa+SZB9qA0gLY/4to=; b=OW5xIQqZh4SJPIcL+PTY7EOxGJazzCIaZuxiV/qTin3RT7h1hGZ4IF0FiESW4+7EX5 y6yj7RsTFKOPnW9C0pMaNow+ZLlILFTxtfq3Yi09liGllpJoeC15NARqkJzvSzuD/GCP MHpSRP2kzeIvvs3GNO4iDV6hDQANeLOaZqg2K9Ucv2w3a2SErakpULypHVXXxP5tu1+f uvV+4vevdHfnxflASmnjW+SAn2yw12SwjFEuqiXXOsfVRO59e0M1Y72vcBc+XPaOf3Zl ef3zk6QNvttkj5Gm36RHC4qpQk7N1U0/V2A3ic522tyIAlWI4/L1jUPb0kjaNjJjFeqO 1PCA== X-Gm-Message-State: AOJu0Ywpsmz6AICd5a/ZdQ8+nP2DUW/mFUUGmOjlZcl9kmTJLr6O0MGS KbpcnZe4DSg6zFEnHNnhtschd5EabROaVIDjbvGeQ+9dFdAv0TQN X-Google-Smtp-Source: AGHT+IGCNJ84GTkndlVXVW0BhcqWmG6JAv8ASCdYiOPru/zbqMmslZM7/OUr9CAPvqxXjWFb87e6nw== X-Received: by 2002:a17:902:d501:b0:20c:8d7f:8fec with SMTP id d9443c01a7336-20fa9ec345fmr124142995ad.56.1729860932167; Fri, 25 Oct 2024 05:55:32 -0700 (PDT) Received: from mars.local.gmail.com (221x241x217x81.ap221.ftth.ucom.ne.jp. [221.241.217.81]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf46fc5sm8995345ad.45.2024.10.25.05.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 05:55:31 -0700 (PDT) Date: Fri, 25 Oct 2024 21:55:27 +0900 Message-ID: From: Hajime Tazaki To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, ricarkol@google.com Subject: Re: [RFC PATCH 04/13] x86/um: nommu: syscall handling In-Reply-To: References: <1a39a239b4a34d2f613ab1ffc62c80967a2f57fb.1729770373.git.thehajime@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241025_055533_776463_589672F8 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Fri, 25 Oct 2024 18:14:19 +0900, Johannes Berg wrote: > > On Thu, 2024-10-24 at 21:09 +0900, Hajime Tazaki wrote: > > > > +++ b/arch/x86/um/do_syscall_64.c > > @@ -0,0 +1,42 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#ifndef CONFIG_MMU > > This seems unnecessary, you don't build the file with CONFIG_MMU in the > first place. will fix it. > > +++ b/arch/x86/um/entry_64.S > > @@ -0,0 +1,88 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#include "../entry/calling.h" > > + > > +#ifdef CONFIG_SMP > > +#error need to stash these variables somewhere else > > +#endif > > + > > +#ifndef CONFIG_MMU > > same here. will fix it too. > > +++ b/arch/x86/um/shared/sysdep/syscalls_64.h > > @@ -25,4 +25,8 @@ extern syscall_handler_t *sys_call_table[]; > > extern syscall_handler_t sys_modify_ldt; > > extern syscall_handler_t sys_arch_prctl; > > > > +__visible void do_syscall_64(struct pt_regs *regs); > > +extern long __kernel_vsyscall(int64_t a0, int64_t a1, int64_t a2, int64_t a3, > > + int64_t a4, int64_t a5, int64_t a6); > > + > > > > but maybe that should be ifdef'ed? thanks, will fix it too. -- Hajime