From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F406CC53210 for ; Sun, 8 Jan 2023 09:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbjAHJBs (ORCPT ); Sun, 8 Jan 2023 04:01:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230165AbjAHJBr (ORCPT ); Sun, 8 Jan 2023 04:01:47 -0500 Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46527BC26; Sun, 8 Jan 2023 01:01:46 -0800 (PST) Received: from SOPL295.local (unknown [IPv6:2a01:e0a:a6a:5f90:5959:63b1:9783:3e26]) (Authenticated sender: robert.jarzmik@free.fr) by smtp3-g21.free.fr (Postfix) with ESMTPSA id 1B45A13F87E; Sun, 8 Jan 2023 10:01:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1673168504; bh=jN07y0o4PEKT+hhbGgEcvZdsd+ibKgA08wW81JoUNZc=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=ifwFeaaqAL0DtcSDhmdxYoKbxgn7RL5akTq+jbOkcYPa63wTJpMeFU6rtLu35fH19 Z87Mt/9UuWXDpcY4dHlXP6E8YZSaRRIo/lFdceyVxXJ+2sQGfHP3kXxHaY1zS/1w/8 c+wfslIBoPsit+xrsR61Z1SeeqE6weDcHoBv2kOe7SuMcEWHd2jPYGWEqljsj6n8TR 7wFQb7NpB+6S4r3Zxf5izc4bkESQwLua6rpX4q80OGW5iHsc6h3qZWyYjWNY9mALuh Azwl0H3U5ucIylDrJW09TAFFmeE1rQIKEytClw4kgPoiSrobm+yfWSs5ILoACwQl55 PLjDeBmsZFbhw== References: <20230105134622.254560-1-arnd@kernel.org> <20230105134622.254560-5-arnd@kernel.org> User-agent: mu4e 1.8.11; emacs 28.1 From: Robert Jarzmik To: Arnd Bergmann Cc: Robert Jarzmik , Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Ulf Hansson , Dominik Brodowski , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 04/27] ARM: pxa: drop pxa310/pxa320/pxa93x support Date: Sun, 08 Jan 2023 09:49:17 +0100 In-reply-to: <20230105134622.254560-5-arnd@kernel.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Arnd Bergmann writes: > There is currently no devicetree support for any of these three > SoCs, and no board files remain. As it seems unlikely that > anyone > is going to add DT support soon, let's drop the SoC specific > code > now. Hi Arnd, Here you're dropping pxa variant support. For the currently "partly" working boards in devicetree, such a zylonite, this will break their current support. For example the zylonite I have which is working on DT has a pxa310 variant. The cm-x300, which also works in DT, has a pxa320 variant. What these boards need is their IO mappings and cpufreq to still work after your serie in DT. What bothers me are the changes to : - drivers/clk/pxa/clk-pxa3xx.c - drivers/cpufreq/pxa3xx-cpufreq.c Here the clock changes will probably remove the clock provided to specific pxa310/pxa320 drivers for example. I don't know how you want to proceed, yet this change will break some pxa3xx platforms. Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78F15C54EBC for ; Sun, 8 Jan 2023 09:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc: To:From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kMiWjl3wRmLOyKUuUlTav2Ka4FjKZPPdkOa7xIOAhFQ=; b=0Q70W0vWhs0MxBqaNFSEAdX0tu oPdWKhYgCRQMqFFDfVmqaOkHkqfW5DuuxVs/4u7z5nuf42VR+l+ADsZfADt5rWe694/6PsKnAW6ac KCvvSFM3M0LqClUDcwVItRQZsDiiR3dYOMrQ6TIxut/CRBJGXBV9QdtZWwX0/3XnsHO6T9xYuleh2 8+nFVdaHfj8kBziq7ajOb9v/Ugc8liySYXKFNiYu9mt0SwAU3HpIyZISuXJjff1w8Q0gpIVgfZuq2 v6RquzxTwkQG8Fw58/2Xxa+IfrLZ1fRirL8doXewZw5z9uNQC0i0q3l2VAhwrNfgWbRZjctteToRf t3ow888g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pERYx-00CFU6-6K; Sun, 08 Jan 2023 09:01:55 +0000 Received: from smtp3-g21.free.fr ([2a01:e0c:1:1599::12]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pERYt-00CFRg-6G for linux-arm-kernel@lists.infradead.org; Sun, 08 Jan 2023 09:01:53 +0000 Received: from SOPL295.local (unknown [IPv6:2a01:e0a:a6a:5f90:5959:63b1:9783:3e26]) (Authenticated sender: robert.jarzmik@free.fr) by smtp3-g21.free.fr (Postfix) with ESMTPSA id 1B45A13F87E; Sun, 8 Jan 2023 10:01:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1673168504; bh=jN07y0o4PEKT+hhbGgEcvZdsd+ibKgA08wW81JoUNZc=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=ifwFeaaqAL0DtcSDhmdxYoKbxgn7RL5akTq+jbOkcYPa63wTJpMeFU6rtLu35fH19 Z87Mt/9UuWXDpcY4dHlXP6E8YZSaRRIo/lFdceyVxXJ+2sQGfHP3kXxHaY1zS/1w/8 c+wfslIBoPsit+xrsR61Z1SeeqE6weDcHoBv2kOe7SuMcEWHd2jPYGWEqljsj6n8TR 7wFQb7NpB+6S4r3Zxf5izc4bkESQwLua6rpX4q80OGW5iHsc6h3qZWyYjWNY9mALuh Azwl0H3U5ucIylDrJW09TAFFmeE1rQIKEytClw4kgPoiSrobm+yfWSs5ILoACwQl55 PLjDeBmsZFbhw== References: <20230105134622.254560-1-arnd@kernel.org> <20230105134622.254560-5-arnd@kernel.org> User-agent: mu4e 1.8.11; emacs 28.1 From: Robert Jarzmik To: Arnd Bergmann Cc: Robert Jarzmik , Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Ulf Hansson , Dominik Brodowski , linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 04/27] ARM: pxa: drop pxa310/pxa320/pxa93x support Date: Sun, 08 Jan 2023 09:49:17 +0100 In-reply-to: <20230105134622.254560-5-arnd@kernel.org> Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230108_010151_715113_3EF97E00 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > There is currently no devicetree support for any of these three > SoCs, and no board files remain. As it seems unlikely that > anyone > is going to add DT support soon, let's drop the SoC specific > code > now. Hi Arnd, Here you're dropping pxa variant support. For the currently "partly" working boards in devicetree, such a zylonite, this will break their current support. For example the zylonite I have which is working on DT has a pxa310 variant. The cm-x300, which also works in DT, has a pxa320 variant. What these boards need is their IO mappings and cpufreq to still work after your serie in DT. What bothers me are the changes to : - drivers/clk/pxa/clk-pxa3xx.c - drivers/cpufreq/pxa3xx-cpufreq.c Here the clock changes will probably remove the clock provided to specific pxa310/pxa320 drivers for example. I don't know how you want to proceed, yet this change will break some pxa3xx platforms. Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel