From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Tue, 16 Aug 2016 08:12:45 -0500 Subject: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all() In-Reply-To: <1470225791-16613-5-git-send-email-wagi@monom.org> (Daniel Wagner's message of "Wed, 3 Aug 2016 14:03:11 +0200") References: <1470225791-16613-1-git-send-email-wagi@monom.org> <1470225791-16613-5-git-send-email-wagi@monom.org> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Daniel Wagner writes: > From: Daniel Wagner > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the completion is: > > meson_i2c_xfer_msg() > reinit_completion() > ... > /* Start the transfer */ > ... > wait_for_completion_timeout() > > Signed-off-by: Daniel Wagner Acked-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all() Date: Tue, 16 Aug 2016 08:12:45 -0500 Message-ID: References: <1470225791-16613-1-git-send-email-wagi@monom.org> <1470225791-16613-5-git-send-email-wagi@monom.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1470225791-16613-5-git-send-email-wagi@monom.org> (Daniel Wagner's message of "Wed, 3 Aug 2016 14:03:11 +0200") Sender: linux-kernel-owner@vger.kernel.org To: Daniel Wagner Cc: Wolfram Sang , Kamal Dasu , Tim Kryger , Ray Jui , Daniel Wagner , linux-kernel@vger.kernel.org, Beniamino Galvani , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-i2c@vger.kernel.org Daniel Wagner writes: > From: Daniel Wagner > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the completion is: > > meson_i2c_xfer_msg() > reinit_completion() > ... > /* Start the transfer */ > ... > wait_for_completion_timeout() > > Signed-off-by: Daniel Wagner Acked-by: Kevin Hilman From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Tue, 16 Aug 2016 08:12:45 -0500 Subject: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all() In-Reply-To: <1470225791-16613-5-git-send-email-wagi@monom.org> (Daniel Wagner's message of "Wed, 3 Aug 2016 14:03:11 +0200") References: <1470225791-16613-1-git-send-email-wagi@monom.org> <1470225791-16613-5-git-send-email-wagi@monom.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Daniel Wagner writes: > From: Daniel Wagner > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the completion is: > > meson_i2c_xfer_msg() > reinit_completion() > ... > /* Start the transfer */ > ... > wait_for_completion_timeout() > > Signed-off-by: Daniel Wagner Acked-by: Kevin Hilman