[meta-fsl-arm][RFC][PATCH] qtbase: Fix xcb can't create OpenGL context error

[meta-fsl-arm][RFC][PATCH] qtbase: Fix xcb can't create OpenGL context error

[Yen-Chin Lee]

Make qtbase include qeglfshooks_imx6.cpp when build with X11, without
this the xcb platform would compliant that no GLX nor
EGL are enabled.

This bug was introduced in commit 55399e0.

Signed-off-by: Yen-Chin Lee <coldnew.tw@gmail.com>
---
 qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend b/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
index 64966c2..a71a198 100644
--- a/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
+++ b/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
@@ -45,17 +45,12 @@ do_configure_prepend_mx6() {
 	# adapt qmake.conf to our needs
 	sed -i 's!load(qt_config)!!' ${S}/mkspecs/linux-oe-g++/qmake.conf
     if test ${HAS_X11} -eq 0; then
-   if test ${IS_MX6SL} -eq 0; then
     
 		cat >> ${S}/mkspecs/linux-oe-g++/qmake.conf <<EOF
 EGLFS_PLATFORM_HOOKS_SOURCES = \$\$PWD/qeglfshooks_imx6.cpp
 IMX6_CFLAGS             = -DLINUX=1 -DEGL_API_FB=1
 EOF
-   else
-cat >> ${S}/mkspecs/linux-oe-g++/qmake.conf <<EOF
-IMX6_CFLAGS             = -DLINUX=1
-EOF
-fi
+		
 		# copy the hook in the mkspecs directory OE is using
 		cp ${S}/mkspecs/devices/linux-imx6-g++/qeglfshooks_imx6.cpp ${S}/mkspecs/linux-oe-g++/
 	else
-- 
1.9.2

Re: [meta-fsl-arm][RFC][PATCH] qtbase: Fix xcb can't create OpenGL context error

[Otavio Salvador]

Hello Yen-Chin,

On Wed, Oct 15, 2014 at 12:47 PM, Yen-Chin Lee <coldnew.tw@gmail.com> wrote:
> Make qtbase include qeglfshooks_imx6.cpp when build with X11, without
> this the xcb platform would compliant that no GLX nor
> EGL are enabled.
>
> This bug was introduced in commit 55399e0.
>
> Signed-off-by: Yen-Chin Lee <coldnew.tw@gmail.com>

I am adding Neena, who did the commit which broke it, in Cc so she can
comment, test and send feedback about the patch.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][RFC][PATCH] qtbase: Fix xcb can't create OpenGL context error

[Neena Busireddy]

Hi Yen-Chin,

That was not the bug. I just included a special case for sololite ( Sololite does not support 3D GPU hardware acceleration) for
non-X11 builds. Without this patch, sololite non-x11 (frame buffer and Wayland) builds are broken. To my knowledge, we do not hook eglfs for X11 backend.

Also, your patch does not include qeglfshooks_imx6.cpp for X11 backend.

However, could you please let me know the steps to reproduce the error and the machine you are trying to build?

Thanks,
Neena Busireddy

-----Original Message-----
From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf Of Otavio Salvador
Sent: Wednesday, October 15, 2014 1:50 PM
To: Yen-Chin Lee; Busireddy Neena-B45787
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm][RFC][PATCH] qtbase: Fix xcb can't create OpenGL context error

Hello Yen-Chin,

On Wed, Oct 15, 2014 at 12:47 PM, Yen-Chin Lee <coldnew.tw@gmail.com> wrote:
> Make qtbase include qeglfshooks_imx6.cpp when build with X11, without 
> this the xcb platform would compliant that no GLX nor EGL are enabled.
>
> This bug was introduced in commit 55399e0.
>
> Signed-off-by: Yen-Chin Lee <coldnew.tw@gmail.com>

I am adding Neena, who did the commit which broke it, in Cc so she can comment, test and send feedback about the patch.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][RFC][PATCH] qtbase: Fix xcb can't create OpenGL context error

[Yen-Chin Lee]

Hello Neena,

Sorry, please ignore this patch.

I testing this on my company's device, which is based on wandboard with
i.MX6DL CPU.

It seems like there's some problem on my qt-build (5.3.2), since I just
test the Qt under wayland before and try to switch to X11.

after

`bitbake -c cleanall qtbase; bitbake qtbase`

the problem seems gone.

Neena Busireddy writes:

> Hi Yen-Chin,
>
> That was not the bug. I just included a special case for sololite ( Sololite does not support 3D GPU hardware acceleration) for
> non-X11 builds. Without this patch, sololite non-x11 (frame buffer and Wayland) builds are broken. To my knowledge, we do not hook eglfs for X11 backend.
>
> Also, your patch does not include qeglfshooks_imx6.cpp for X11 backend.

  Yes, after review the code, when I build DISTRO_FEATURES with X11, it
  would not include qeglfshooks_imx6.cpp. So this is not bug.

>
> However, could you please let me know the steps to reproduce the error and the machine you are trying to build?
>
> Thanks,
> Neena Busireddy
>
> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf Of Otavio Salvador
> Sent: Wednesday, October 15, 2014 1:50 PM
> To: Yen-Chin Lee; Busireddy Neena-B45787
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-arm][RFC][PATCH] qtbase: Fix xcb can't create OpenGL context error
>
> Hello Yen-Chin,
>
> On Wed, Oct 15, 2014 at 12:47 PM, Yen-Chin Lee <coldnew.tw@gmail.com> wrote:
>> Make qtbase include qeglfshooks_imx6.cpp when build with X11, without
>> this the xcb platform would compliant that no GLX nor EGL are enabled.
>>
>> This bug was introduced in commit 55399e0.
>>
>> Signed-off-by: Yen-Chin Lee <coldnew.tw@gmail.com>
>
> I am adding Neena, who did the commit which broke it, in Cc so she can comment, test and send feedback about the patch.

--
Sent with my mu4e