From: Andi Kleen <andi@firstfloor.org>
To: stefani@seibold.net
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
oneukum@suse.de, alan@lxorguk.ukuu.org.uk,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 10/11] Introduce single user mode
Date: Thu, 07 Jun 2012 10:48:16 -0700 [thread overview]
Message-ID: <m2sje7hv33.fsf@firstfloor.org> (raw)
In-Reply-To: <1339000274-10448-1-git-send-email-stefani@seibold.net> (stefani@seibold.net's message of "Wed, 6 Jun 2012 18:31:13 +0200")
stefani@seibold.net writes:
> }
>
> + if (dev->in_use) {
> + retval = -EBUSY;
> + goto exit;
> + }
This plus setting the flag has to be inside the mutex, otherwise you
have an obvious race.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-06-07 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 16:31 [PATCH 10/11] Introduce single user mode stefani
2012-06-06 16:31 ` [PATCH 11/11] Bump version number and add aditional author stefani
2012-06-07 17:48 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-06 16:27 [PATCH] fix usb skeleton driver stefani
2012-06-06 16:27 ` [PATCH 10/11] Introduce single user mode stefani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sje7hv33.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.