From: Andreas Schwab <schwab@linux-m68k.org>
To: Vincent van Ravesteijn <vfr@lyx.org>
Cc: git@vger.kernel.org, msysgit@googlegroups.com, gitster@pobox.com,
kusmabite@gmail.com, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH 1/2] MSVC: Do not close stdout to prevent a crash
Date: Sat, 19 Nov 2011 15:41:38 +0100 [thread overview]
Message-ID: <m2sjlkcgyl.fsf@igel.home> (raw)
In-Reply-To: <1321710345-2299-1-git-send-email-vfr@lyx.org> (Vincent van Ravesteijn's message of "Sat, 19 Nov 2011 14:45:44 +0100")
Vincent van Ravesteijn <vfr@lyx.org> writes:
> When compiled with MSVC, git crashes on Windows when calling
> fstat(stdout) when stdout is closed. fstat is being called at the end of
ITYM fileno(stdout).
> run_builtin and this will thus be a problem for builtin command that close
> stdout. This happens for 'format-patch' which closes stdout after a call to
> freopen which directs stdout to the format patch file.
It shouldn't do that in the first place. This is an error on any
platform.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-11-19 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 13:45 [PATCH 1/2] MSVC: Do not close stdout to prevent a crash Vincent van Ravesteijn
2011-11-19 13:52 ` [PATCH 2/2] MSVC: Use _putenv instead of putenv " Vincent van Ravesteijn
2011-11-19 14:41 ` Andreas Schwab [this message]
2011-11-19 19:11 ` [PATCH 1/2] MSVC: Do not close stdout " Junio C Hamano
2011-11-19 20:16 ` Andreas Schwab
2011-11-20 3:27 ` Junio C Hamano
2011-11-20 9:05 ` Andreas Schwab
2011-11-20 9:27 ` [msysGit] " Johannes Sixt
2011-11-20 21:10 ` Junio C Hamano
2011-11-19 20:52 ` Vincent van Ravesteijn
2011-11-19 20:11 ` [msysGit] " Johannes Sixt
2011-11-22 6:45 ` Vincent van Ravesteijn
2011-11-22 20:24 ` Johannes Sixt
2011-11-22 21:27 ` Vincent van Ravesteijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sjlkcgyl.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=vfr@lyx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.