All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Rename getenv_r() into getenv_f()
Date: Thu, 29 Jul 2010 13:30:16 +0200	[thread overview]
Message-ID: <m2sk32fruf.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1280001343-1460-1-git-send-email-wd@denx.de> (Wolfgang Denk's message of "Sat, 24 Jul 2010 21:55:43 +0200")

Hi Wolfgang,

> While running from flash, i. e. before relocation, we have only a
> limited C runtime environment without writable data segment. In this
> phase, some configurations (for example with environment in EEPROM)
> must not use the normal getenv(), but a special function.  This
> function had been called getenv_r(), with the idea that the "_r"
> suffix would mean the same as in the _r_eentrant versions of some of
> the C library functions (for example getdate vs. getdate_r, getgrent
> vs. getgrent_r, etc.).
>
> Unfortunately this was a misleading name, as in U-Boot the "_r"
> generally means "running from RAM", i. e. _after_ relocation.
>
> To avoid confusion, rename into getenv_f() [as "running from flash"]

I appreciatethis change as I was mislead also once about the nameing.

> Signed-off-by: Wolfgang Denk <wd@denx.de>

Acked-by: Detlev Zundel <dzu@denx.de>

Cheers
  Detlev

-- 
Q: Does that mean we also shouldn't be using IRQF_SAMPLE_RANDOM on
   interrupt [sources]?
A: Yes. The flag needs to be taken out and shot.
                            -- Matt Mackall <1239116251.14392.133.camel@calx>
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2010-07-29 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24 19:55 [U-Boot] [PATCH] Rename getenv_r() into getenv_f() Wolfgang Denk
2010-07-29 11:30 ` Detlev Zundel [this message]
2010-08-03 22:45 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2sk32fruf.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.