From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] [v2] cmd_nand: add nand write.trimffs command
Date: Tue, 24 May 2011 15:22:08 +0200 [thread overview]
Message-ID: <m2tyckterj.fsf@ohwell.denx.de> (raw)
In-Reply-To: <cb0599fadbf1934ae6ba17d9ea5b7afbff83859d.1305823168.git.bengardiner@nanometrics.ca> (Ben Gardiner's message of "Thu, 19 May 2011 12:49:25 -0400")
Hi Ben,
> Add another nand write. variant, trimffs. This command will request of
> nand_write_skip_bad() that all trailing all-0xff pages will be
> dropped from eraseblocks when they are written to flash as-per the
> reccommended behaviour of the UBI FAQ [1].
>
> The function that implements this timming is the drop_ffs() function
> by Artem Bityutskiy, ported from the mtd-utils tree.
>
> [1] http://www.linux-mtd.infradead.org/doc/ubi.html#L_flasher_algo
>
> Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
> CC: Artem Bityutskiy <dedekind1@gmail.com>
> CC: Detlev Zundel <dzu@denx.de>
>
> ---
>
> Detlev,
> I did not do any erased-state checks since the implicit assumption
> in other nand commands is that the user is required to do their
> own erasing beforehand.
Yes, I have come to the same conclusion.
I have another request though - please add the new command to
doc/README.nand. Thanks!
Cheers
Detlev
--
Modern technique has made it possible for leisure, within limits, to be not
the prerogative of small privileged classes, but a right evenly distributed
throughout the community. The morality of work is the morality of slaves,
and the modern world has no need of slavery. -- Bertrand Russell
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-05-24 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 16:49 [U-Boot] [PATCH v2 0/4] introduce nand write.trimffs Ben Gardiner
2011-05-19 16:49 ` [U-Boot] [PATCH 1/4] [v2] nand_base: trivial: fix comment read/write comment Ben Gardiner
2011-05-24 12:36 ` Detlev Zundel
2011-05-19 16:49 ` [U-Boot] [PATCH 2/4] [v2] nand_util: convert nand_write_skip_bad() to flags Ben Gardiner
2011-05-24 13:17 ` Detlev Zundel
2011-05-24 13:27 ` Ben Gardiner
2011-05-19 16:49 ` [U-Boot] [PATCH 3/4] [v2] nand_util: drop trailing all-0xff pages if requested Ben Gardiner
2011-05-24 13:23 ` Detlev Zundel
2011-05-19 16:49 ` [U-Boot] [PATCH 4/4] [v2] cmd_nand: add nand write.trimffs command Ben Gardiner
2011-05-24 13:22 ` Detlev Zundel [this message]
2011-05-24 13:30 ` Ben Gardiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tyckterj.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.