From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific
Date: Thu, 16 Sep 2010 14:05:08 +0200 [thread overview]
Message-ID: <m2tylpzyff.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1284366840-31651-1-git-send-email-sr@denx.de> (Stefan Roese's message of "Mon, 13 Sep 2010 10:34:00 +0200")
Hi Stefan,
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> arch/blackfin/cpu/cmd_gpio.c | 2 +-
> arch/blackfin/cpu/gpio.c | 2 +-
> arch/powerpc/cpu/ppc4xx/cpu_init.c | 2 +-
> arch/powerpc/cpu/ppc4xx/gpio.c | 2 +-
> arch/powerpc/include/asm/{gpio.h => ppc4xx-gpio.h} | 0
> board/amcc/acadia/memory.c | 2 +-
> board/amcc/bamboo/bamboo.c | 2 +-
> board/amcc/canyonlands/canyonlands.c | 2 +-
> board/amcc/katmai/katmai.c | 2 +-
> board/amcc/makalu/makalu.c | 2 +-
> board/amcc/sequoia/sequoia.c | 2 +-
> board/amcc/taihu/lcd.c | 2 +-
> board/amcc/taihu/taihu.c | 2 +-
> board/bf527-ezkit/bf527-ezkit.c | 2 +-
> board/bf533-stamp/bf533-stamp.c | 2 +-
> board/bf548-ezkit/bf548-ezkit.c | 2 +-
> board/bf548-ezkit/video.c | 2 +-
> board/blackstamp/blackstamp.c | 2 +-
> board/cm-bf527/gpio_cfi_flash.c | 2 +-
> board/cm-bf537e/gpio_cfi_flash.c | 2 +-
> board/cm-bf537u/gpio_cfi_flash.c | 2 +-
> board/cm-bf548/video.c | 2 +-
> board/esd/pmc405de/pmc405de.c | 2 +-
> board/gdsys/dlvision/dlvision.c | 2 +-
> board/gdsys/intip/intip.c | 2 +-
> board/korat/korat.c | 2 +-
> board/lwmon5/lwmon5.c | 2 +-
> board/mosaixtech/icon/icon.c | 2 +-
> board/quad100hd/nand.c | 2 +-
> board/quad100hd/quad100hd.c | 2 +-
> board/t3corp/t3corp.c | 2 +-
> board/tcm-bf537/gpio_cfi_flash.c | 2 +-
> board/zeus/update.c | 2 +-
> board/zeus/zeus.c | 2 +-
> drivers/i2c/soft_i2c.c | 2 +-
> drivers/misc/gpio_led.c | 2 +-
> drivers/mtd/nand/nand_plat.c | 2 +-
> drivers/spi/bfin_spi.c | 2 +-
> post/board/lwmon5/watchdog.c | 2 +-
> 39 files changed, 38 insertions(+), 38 deletions(-)
> rename arch/powerpc/include/asm/{gpio.h => ppc4xx-gpio.h} (100%)
>
> diff --git a/arch/blackfin/cpu/cmd_gpio.c b/arch/blackfin/cpu/cmd_gpio.c
> index 4430c90..5e87e2b 100644
> --- a/arch/blackfin/cpu/cmd_gpio.c
> +++ b/arch/blackfin/cpu/cmd_gpio.c
> @@ -10,7 +10,7 @@
> #include <command.h>
>
> #include <asm/blackfin.h>
> -#include <asm/gpio.h>
> +#include <asm/ppc4xx-gpio.h>
This really defeats the symlinking of the asm directory and using
generic names. I believe you will break lots of non-4xx boards with
this change. In other words, did you try a Blackfin build with this
change? ;)
Cheers
Detlev
--
Cyberwar is certainly not a myth. But you haven't seen it yet, despite
the attacks on Estonia. Cyberwar is warfare in cyberspace. And warfare
involves massive death and destruction. When you see it, you'll know it.
-- Bruce Schneier, Nov. 2007
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2010-09-16 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 8:34 [U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific Stefan Roese
2010-09-16 12:05 ` Detlev Zundel [this message]
2010-09-16 12:18 ` Stefan Roese
2010-09-16 13:00 ` Detlev Zundel
2010-09-16 13:47 ` Stefan Roese
2010-09-22 20:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tylpzyff.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.