From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F011917F9 for ; Sun, 16 Feb 2025 12:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739709655; cv=none; b=K8P/1Bo38iJ3vw/1nwrFE9Ch82cb+RvlxneF9mQReAN7nzueflZpHlC4FoGkDwBupqvy1KEHrIBSzt0UL8SCQtx9jo3DbNhju203zBHLGpAnMeFZqcLIhwnGG3Vd2i+8Jv1fKhnKL7CPR+xhrD5jXRcI1pqgCYgQSKIS2M7gyGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739709655; c=relaxed/simple; bh=Sc85HGzsFWfaGk/iyYFW84nqwWegZPXqD9lfA1Wbgl8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZiVkmtqlU5bbFPXNnb0Z4c+5fnm2Hr/ueSbWWmaB71JvYjRuIFxxs2cZMGRZAjev7izQCzlSktlpCiWgQVe8e1Yz/jrPxiMh7XRjzzqfyMHfzwhsr+HXVaLAgN/1WEcShoLTHEeFuwLa4/3d822VtHkweLB2UIDIJteEU9NvDOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net; spf=pass smtp.mailfrom=posteo.net; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b=Rzb0CxzJ; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b="Rzb0CxzJ" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 86E57240029 for ; Sun, 16 Feb 2025 13:40:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1739709650; bh=Sc85HGzsFWfaGk/iyYFW84nqwWegZPXqD9lfA1Wbgl8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Rzb0CxzJve8CE/LMVHheOE4GraSzgepj/E2ebT0GYsSIZVVTcdCi7b0wbSudZxR1a qA0LDn0ZXcu8pvVFj2Ew8MSY9XTE/3W3bMDad1RWiNYvzw6C3dV1PlEXKJAvDljrEp z1fgcf42F0nr/JMso5utMo1wevL2ZlPXSzGzzutMrvhLaBcWZiM3mBpA4VOXg7sUEu UpFFSabVH/Pkj4sKF8SKJFTg6JYZ1uTncFduumBS6gBQZHXslNzJjFgBO9+GLvgLWO wos7+ASA7DNPCyqSkD7gWCOzAVWNLA4T/ONXJ3jDp7plszo/fHhRXaFBsszi6hU10Y RonxCxr+2tclw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ywlkl1pHmz6tvq; Sun, 16 Feb 2025 13:40:47 +0100 (CET) From: Charalampos Mitrodimas To: Benno Lossin Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6?= =?utf-8?Q?rn?= Roy Baron , Andreas Hindborg , Alice Ryhl , Trevor Gross , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Wedson Almeida Filho , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] rust: fix clippy::too-long-first-doc-paragraph In-Reply-To: <10690211-eb3b-4b95-8d9d-35c62930d924@proton.me> References: <20250215223106.2346285-1-benno.lossin@proton.me> <10690211-eb3b-4b95-8d9d-35c62930d924@proton.me> Date: Sun, 16 Feb 2025 12:40:46 +0000 Message-ID: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Benno Lossin writes: > On 16.02.25 01:12, Charalampos Mitrodimas wrote: >> Benno Lossin writes: >> [..snip..] >> Hi, >> >> I cannot reproduce this as-is, but adding >> "-Wclippy::too_long_first_doc_paragraph" to the "rust_common_flags" in >> the Makefile reproduces it. Maybe try adding it there in your patch? > > I have done some more digging and bisected my Rust version. It turns out > I was on a rather old nightly from last September. I also don't get the > error on a newer compiler version. My bisection identified that the > error last occurs in nightly 2024-10-18, so from 2024-10-19 onwards it > compiles without the error. > So probably `-Wclippy::all` implied the `too_long_first_doc_paragraph` > lint in that version. That is probably because of [1]. It changes the > lint from style to nursery. > > [1]: https://github.com/rust-lang/rust-clippy/pull/13551 > > So we don't need this patch, as it seems this never hit stable. However, > there is already a patch fixing what this lint reports: 2f390cc58943 > ("rust: provide proper code documentation titles"). > > I think it's a good lint, so maybe we should turn it on? Given the critical importance of readable documentation, I agree. > > --- > Cheers, > Benno