Re: [PATCH net-next] tools: pynl: make flags argument optional for do()

[Donald Hunter <donald.hunter@gmail.com>]

Jakub Kicinski <kuba@kernel.org> writes:

> Commit 1768d8a767f8 ("tools/net/ynl: Add support for create flags")
> added support for setting legacy netlink CRUD flags on netlink
> messages (NLM_F_REPLACE, _EXCL, _CREATE etc.).
>
> Most of genetlink won't need these, don't force callers to pass
> in an empty argument to each do() call.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

> ---
>  tools/net/ynl/lib/ynl.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
> index 92995bca14e1..c56dad9593c6 100644
> --- a/tools/net/ynl/lib/ynl.py
> +++ b/tools/net/ynl/lib/ynl.py
> @@ -705,7 +705,7 @@ genl_family_name_to_id = None
>  
>        return op['do']['request']['attributes'].copy()
>  
> -    def _op(self, method, vals, flags, dump=False):
> +    def _op(self, method, vals, flags=None, dump=False):
>          op = self.ops[method]
>  
>          nl_flags = Netlink.NLM_F_REQUEST | Netlink.NLM_F_ACK
> @@ -769,7 +769,7 @@ genl_family_name_to_id = None
>              return rsp[0]
>          return rsp
>  
> -    def do(self, method, vals, flags):
> +    def do(self, method, vals, flags=None):
>          return self._op(method, vals, flags)
>  
>      def dump(self, method, vals):