All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew W Elble <aweits@rit.edu>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/5] nfsd: Fix stateid races between OPEN and CLOSE
Date: Tue, 31 Oct 2017 18:33:41 -0400	[thread overview]
Message-ID: <m2vaivrlq2.fsf@discipline.rit.edu> (raw)
In-Reply-To: <20171031000951.18294-2-trond.myklebust@primarydata.com> (Trond Myklebust's message of "Mon, 30 Oct 2017 20:09:47 -0400")


Not directly related to this patch series, but:

I keep staring at the failure path in nfsd4_process_open2() from the
call to nfs4_get_vfs_file() and thinking that there's a missing state
change to the stateid that's still hashed before the mutex is dropped
and the call to release_open_stateid()?

Thanks,

Andy

-- 
Andrew W. Elble
aweits@discipline.rit.edu
Infrastructure Engineer, Communications Technical Lead
Rochester Institute of Technology
PGP: BFAD 8461 4CCF DC95 DA2C B0EB 965B 082E 863E C912

  parent reply	other threads:[~2017-10-31 22:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31  0:09 [PATCH 0/5] Tighten up locking around stateids in knfsd Trond Myklebust
2017-10-31  0:09 ` [PATCH 1/5] nfsd: Fix stateid races between OPEN and CLOSE Trond Myklebust
2017-10-31  0:09   ` [PATCH 2/5] nfsd: CLOSE SHOULD return the invalid special stateid for NFSv4.x (x>0) Trond Myklebust
2017-10-31  0:09     ` [PATCH 3/5] nfsd: Ensure we don't recognise lock stateids after freeing them Trond Myklebust
2017-10-31  0:09       ` [PATCH 4/5] nfsd: Ensure we check stateid validity in the seqid operation checks Trond Myklebust
2017-10-31  0:09         ` [PATCH 5/5] nfsd: Fix races with check_stateid_generation() Trond Myklebust
2017-10-31 17:32     ` [PATCH 2/5] nfsd: CLOSE SHOULD return the invalid special stateid for NFSv4.x (x>0) Frank Filz
2017-10-31 22:33   ` Andrew W Elble [this message]
2017-10-31 23:24     ` [PATCH 1/5] nfsd: Fix stateid races between OPEN and CLOSE Trond Myklebust
2017-10-31 23:45       ` Andrew W Elble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2vaivrlq2.fsf@discipline.rit.edu \
    --to=aweits@rit.edu \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.