From: Andreas Schwab <schwab@linux-m68k.org>
To: Jeff King <peff@peff.net>
Cc: Lars Winterfeld <lars.winterfeld@tu-ilmenau.de>, git@vger.kernel.org
Subject: Re: bug: "fatal: cannot pread pack file", version 1.7.5.4
Date: Tue, 03 Jul 2012 00:43:42 +0200 [thread overview]
Message-ID: <m2vci5n5r5.fsf@igel.home> (raw)
In-Reply-To: <20120702215736.GA5790@sigill.intra.peff.net> (Jeff King's message of "Mon, 2 Jul 2012 17:57:36 -0400")
Jeff King <peff@peff.net> writes:
> It's very odd for pread to report ENOENT (since it is always operating
> on an already-opened file descriptor).
It doesn't, but gettext will clobber errno:
n = pread(pack_fd, inbuf, n, from);
if (n < 0)
die_errno(_("cannot pread pack file"));
There is nothing that saves errno. This isn't limited to i18n though,
any function call in the arguments may potentially clobber errno.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-07-02 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 19:03 bug: "fatal: cannot pread pack file", version 1.7.5.4 Lars Winterfeld
2012-07-02 21:45 ` Junio C Hamano
2012-07-02 21:57 ` Jeff King
2012-07-02 22:43 ` Andreas Schwab [this message]
2012-07-02 23:50 ` Junio C Hamano
2012-07-03 3:45 ` Jeff King
2012-07-03 4:25 ` Nguyen Thai Ngoc Duy
2012-07-03 5:14 ` Jeff King
2012-07-03 17:16 ` Junio C Hamano
2012-08-16 21:51 ` Junio C Hamano
2012-08-16 22:10 ` Lars Winterfeld
2012-08-16 23:05 ` Junio C Hamano
2012-08-16 23:36 ` Lars Winterfeld
2012-08-17 1:45 ` Jeff King
2012-08-17 3:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vci5n5r5.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=lars.winterfeld@tu-ilmenau.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.