From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
horms@kernel.org
Subject: Re: [PATCH net-next 2/2] netlink: specs: nlctrl: let getfamily take a family id
Date: Thu, 17 Sep 2026 09:56:24 +0100 [thread overview]
Message-ID: <m2wlskntmv.fsf@gmail.com> (raw)
In-Reply-To: <20260916021516.1701760-2-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> ctrl_policy_family[] accepts CTRL_ATTR_FAMILY_ID and ctrl_getfamily()
> looks the family up by it, but the spec lists only family-name in the
> request. C YNL generates struct members and setters from that list, so
> struct nlctrl_getfamily_req has no way to carry an id and resolving a
> family id - the one a client gets handed in nlmsg_type - back to a name
> needs a full dump.
>
> Python YNL happens to encode any attribute of the op's attribute set,
> which is why this went unnoticed.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2026-09-17 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 2:15 [PATCH net-next 1/2] netlink: specs: nlctrl: fix the policy attribute numbering Jakub Kicinski
2026-09-16 2:15 ` [PATCH net-next 2/2] netlink: specs: nlctrl: let getfamily take a family id Jakub Kicinski
2026-09-17 8:56 ` Donald Hunter [this message]
2026-09-17 8:56 ` [PATCH net-next 1/2] netlink: specs: nlctrl: fix the policy attribute numbering Donald Hunter
2026-09-18 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wlskntmv.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.