From: Donald Hunter <donald.hunter@gmail.com>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/8] tools: ynl: fix errors reported by Ruff
Date: Wed, 10 Sep 2025 09:53:11 +0100 [thread overview]
Message-ID: <m2wm66y9hk.fsf@gmail.com> (raw)
In-Reply-To: <20250909-net-next-ynl-ruff-v1-0-238c2bccdd99@kernel.org>
"Matthieu Baerts (NGI0)" <matttbe@kernel.org> writes:
> When looking at the YNL code to add a new feature, my text editor
> automatically executed 'ruff check', and found out at least one
> interesting error: one variable was used while not being defined.
>
> I then decided to fix this error, and all the other ones reported by
> Ruff. After this series, 'ruff check' reports no more errors with
> version 0.12.12.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (8):
> tools: ynl: fix undefined variable name
> tools: ynl: avoid bare except
> tools: ynl: remove assigned but never used variable
> tools: ynl: remove f-string without any placeholders
> tools: ynl: remove unused imports
> tools: ynl: remove unnecessary semicolons
> tools: ynl: use 'cond is None'
> tools: ynl: check for membership with 'not in'
The series looks good to me, thanks for the fixes.
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2025-09-10 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 21:07 [PATCH net-next 0/8] tools: ynl: fix errors reported by Ruff Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 1/8] tools: ynl: fix undefined variable name Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 2/8] tools: ynl: avoid bare except Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 3/8] tools: ynl: remove assigned but never used variable Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 4/8] tools: ynl: remove f-string without any placeholders Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 5/8] tools: ynl: remove unused imports Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 6/8] tools: ynl: remove unnecessary semicolons Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 7/8] tools: ynl: use 'cond is None' Matthieu Baerts (NGI0)
2025-09-09 21:07 ` [PATCH net-next 8/8] tools: ynl: check for membership with 'not in' Matthieu Baerts (NGI0)
2025-09-10 8:53 ` Donald Hunter [this message]
2025-09-10 23:16 ` [PATCH net-next 0/8] tools: ynl: fix errors reported by Ruff Asbjørn Sloth Tønnesen
2025-09-11 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wm66y9hk.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.