From: Charalampos Mitrodimas <charmitro@posteo.net>
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
aliceryhl@google.com, apw@canonical.com, arnd@arndb.de,
aswinunni01@gmail.com, axboe@kernel.dk, benno.lossin@proton.me,
bhelgaas@google.com, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, dakr@kernel.org, dwaipayanray1@gmail.com,
ethan.twardy@gmail.com, fujita.tomonori@gmail.com,
gary@garyguo.net, gregkh@linuxfoundation.org, joe@perches.com,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com,
ojeda@kernel.org, pbonzini@redhat.com,
rust-for-linux@vger.kernel.org, tmgross@umich.edu,
walmeida@microsoft.com
Subject: Re: [PATCH V3 2/2] checkpatch: throw error for malformed arrays
Date: Fri, 21 Feb 2025 17:07:58 +0000 [thread overview]
Message-ID: <m2wmdjtedt.fsf@Mac.home> (raw)
In-Reply-To: <20250221165327.5459-1-trintaeoitogc@gmail.com>
Guilherme Giacomo Simoes <trintaeoitogc@gmail.com> writes:
> Charalampos Mitrodimas <charmitro@posteo.net> wrote:
>> Hi Guilherme,
>>
>> Will this work now that the field is called "authors" and not "author"?
>> I think you forgot to update the regex here.
> I don't know, I make change in modules and samples, and I forget runing again
> the checkpatch.
> Sorry ..
> I will send a v4
Keep in mind that now we also have the faux device sample upstream,
which uses the old single-author module field. Please build against the
latest tree and include the fix for that driver.
It can be found under the path "samples/rust/rust_driver_faux.rs".
>
>> What do you think about this instead?
>> "Prefer each array element on a separate line$herevet"
> For me, looks like great
>
> Thanks,
> Guilherme
prev parent reply other threads:[~2025-02-21 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 16:19 [PATCH V3 0/2] author field in module! macro should be a array Guilherme Giacomo Simoes
2025-02-20 16:19 ` [PATCH V3 1/2] rust: module: change author to an array Guilherme Giacomo Simoes
2025-02-20 16:19 ` [PATCH V3 2/2] checkpatch: throw error for malformed arrays Guilherme Giacomo Simoes
2025-02-20 23:36 ` Charalampos Mitrodimas
2025-02-21 16:53 ` Guilherme Giacomo Simoes
2025-02-21 17:07 ` Charalampos Mitrodimas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wmdjtedt.fsf@Mac.home \
--to=charmitro@posteo.net \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=aswinunni01@gmail.com \
--cc=axboe@kernel.dk \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=ethan.twardy@gmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=ojeda@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=trintaeoitogc@gmail.com \
--cc=walmeida@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.