From: Donald Hunter <donald.hunter@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Jacob Keller <jacob.e.keller@intel.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCHv3 net-next 2/2] doc/netlink/specs: Add vlan attr in rt_link spec
Date: Thu, 28 Mar 2024 15:05:57 +0000 [thread overview]
Message-ID: <m2wmpmjt0q.fsf@gmail.com> (raw)
In-Reply-To: <20240327123130.1322921-3-liuhangbin@gmail.com> (Hangbin Liu's message of "Wed, 27 Mar 2024 20:31:29 +0800")
Hangbin Liu <liuhangbin@gmail.com> writes:
> With command:
> # ./tools/net/ynl/cli.py \
> --spec Documentation/netlink/specs/rt_link.yaml \
> --do getlink --json '{"ifname": "eno1.2"}' --output-json | \
> jq -C '.linkinfo'
>
> Before:
> Exception: No message format for 'vlan' in sub-message spec 'linkinfo-data-msg'
>
> After:
> {
> "kind": "vlan",
> "data": {
> "protocol": "8021q",
> "id": 2,
> "flag": {
> "flags": [
> "reorder-hdr"
> ],
> "mask": "0xffffffff"
> },
> "egress-qos": {
> "mapping": [
> {
> "from": 1,
> "to": 2
> },
> {
> "from": 4,
> "to": 4
> }
> ]
> }
> }
> }
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
next prev parent reply other threads:[~2024-03-28 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 12:31 [PATCHv3 net-next 0/2] doc/netlink/specs: Add vlan support Hangbin Liu
2024-03-27 12:31 ` [PATCHv3 net-next 1/2] ynl: support hex display_hint for integer Hangbin Liu
2024-03-27 12:31 ` [PATCHv3 net-next 2/2] doc/netlink/specs: Add vlan attr in rt_link spec Hangbin Liu
2024-03-28 15:05 ` Donald Hunter [this message]
2024-03-29 1:11 ` [PATCHv3 net-next 0/2] doc/netlink/specs: Add vlan support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wmpmjt0q.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.