From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation Date: Tue, 22 Nov 2016 07:50:06 -0800 Message-ID: References: <20161122014408.22388-1-khilman@baylibre.com> <20161122014408.22388-5-khilman@baylibre.com> <6699f003-a125-1e1b-e161-e9453dad7bdc@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <6699f003-a125-1e1b-e161-e9453dad7bdc@xs4all.nl> (Hans Verkuil's message of "Tue, 22 Nov 2016 13:47:20 +0100") Sender: linux-media-owner@vger.kernel.org To: Hans Verkuil Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Sekhar Nori , Axel Haslam , Bartosz =?utf-8?Q?Go=C5=82aszewski?= , Alexandre Bailon , David Lechner , Rob Herring List-Id: devicetree@vger.kernel.org Hans Verkuil writes: > On 22/11/16 02:44, Kevin Hilman wrote: >> Cc: Rob Herring >> Signed-off-by: Kevin Hilman >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 ++++++++++++++++++++++ >> .../devicetree/bindings/media/ti,da850-vpif.txt | 8 +++ >> 2 files changed, 73 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt >> create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt >> >> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt >> new file mode 100644 >> index 000000000000..bdd93267301f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt >> @@ -0,0 +1,65 @@ >> +Texas Instruments VPIF Capture >> +------------------------------ >> + >> +The TI Video Port InterFace (VPIF) capture component is the primary >> +component for video capture on the DA850 family of TI DaVinci SoCs. >> + >> +TI Document number reference: SPRUH82C >> + >> +Required properties: >> +- compatible: must be "ti,da850-vpif-capture" >> +- reg: physical base address and length of the registers set for the device; >> +- interrupts: should contain IRQ line for the VPIF >> + >> +VPIF capture has a 16-bit parallel bus input, supporting 2 8-bit >> +channels or a single 16-bit channel. It should contain at least one >> +port child node with child 'endpoint' node. Please refer to the >> +bindings defined in >> +Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example using 2 8-bit input channels, one of which is connected to an >> +I2C-connected TVP5147 decoder: >> + >> + vpif_capture: video-capture@0x00217000 { >> + compatible = "ti,vpif-capture"; > > Did you forget to update the compatible string to ti,da850-vpif-capture? > Ugh, yup. v3 coming right up. Kevin