From: Andreas Schwab <schwab@linux-m68k.org>
To: Eric Wong <e@80x24.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] prune: keep files created after process start
Date: Sun, 19 Jun 2016 09:11:38 +0200 [thread overview]
Message-ID: <m2wpllhcut.fsf@linux-m68k.org> (raw)
In-Reply-To: <20160619031338.GA5161@dcvr.yhbt.net> (Eric Wong's message of "Sun, 19 Jun 2016 03:13:38 +0000")
Eric Wong <e@80x24.org> writes:
> @@ -21,7 +22,7 @@ static int prune_tmp_file(const char *fullpath)
> struct stat st;
> if (lstat(fullpath, &st))
> return error("Could not stat '%s'", fullpath);
> - if (st.st_mtime > expire)
> + if (st.st_mtime > expire || st.st_ctime >= start)
That will also mean objects created (or their inode changed) up to a
second before the start of prune will not be removed. For example,
objects ejected out of a pack by a previous repack may be affected.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-06-19 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 3:13 [PATCH] prune: keep files created after process start Eric Wong
2016-06-19 3:58 ` Junio C Hamano
2016-06-19 4:32 ` Eric Wong
2016-06-19 9:34 ` Jeff King
2016-06-19 7:11 ` Andreas Schwab [this message]
2016-06-19 8:48 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wpllhcut.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.