From: Andreas Schwab <schwab@linux-m68k.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Marat Radchenko <marat@slonopotamus.org>, git@vger.kernel.org
Subject: Re: [PATCH v3] MSVC: fix t0040-parse-options crash
Date: Sun, 30 Mar 2014 10:29:04 +0200 [thread overview]
Message-ID: <m2wqfcm6nj.fsf@linux-m68k.org> (raw)
In-Reply-To: <7vtxago359.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sat, 29 Mar 2014 19:01:54 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> As OPT_SET_PTR() is about setting the pointer value to intptr_t defval,
> a follow-up patch on top of this fix (see attached) may not be a bad
> thing to have, but that patch alone will not fix this issue without
> dropping the unneeded and unwanted cast to unsigned long.
Wouldn't it make sense to change defval into a union to avoid the cast?
(The intptr_t type may be too narrow for other values to be put there.)
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2014-03-30 8:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 12:04 [PATCH] MSVC: fix t0040-parse-options Marat Radchenko
2014-03-28 18:19 ` Junio C Hamano
2014-03-29 19:59 ` [PATCH v2] MSVC: fix t0040-parse-options crash Marat Radchenko
2014-03-29 20:09 ` [PATCH v3] " Marat Radchenko
2014-03-29 21:34 ` Andreas Schwab
2014-03-29 22:17 ` René Scharfe
2014-03-30 2:01 ` Junio C Hamano
2014-03-30 8:29 ` Andreas Schwab [this message]
2014-03-31 21:09 ` Jeff King
2014-03-30 11:08 ` [PATCH v4 0/3] Take four on fixing OPT_SET_PTR issues Marat Radchenko
2014-03-30 11:08 ` [PATCH v4 1/3] MSVC: fix t0040-parse-options crash Marat Radchenko
2014-03-30 11:08 ` [PATCH v4 2/3] parse-options: add cast to correct pointer type to OPT_SET_PTR Marat Radchenko
2014-03-31 17:16 ` Junio C Hamano
2014-03-30 11:08 ` [PATCH v4 3/3] parse-options: remove unused OPT_SET_PTR Marat Radchenko
2014-03-31 17:23 ` [PATCH v4 0/3] Take four on fixing OPT_SET_PTR issues Junio C Hamano
2014-03-31 21:07 ` Jeff King
2014-03-31 22:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wqfcm6nj.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marat@slonopotamus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.