From: Chris Ball <cjb@laptop.org>
To: Ulf Hansson <ulf.hansson@stericsson.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 1/2] mmc: core: move ->request() call from atomic context
Date: Mon, 10 Oct 2011 18:05:30 -0400 [thread overview]
Message-ID: <m2wrcclcyd.fsf@bob.laptop.org> (raw)
In-Reply-To: <4E8C6229.6010302@stericsson.com> (Ulf Hansson's message of "Wed, 5 Oct 2011 15:56:57 +0200")
Hi,
On Wed, Oct 05 2011, Ulf Hansson wrote:
> Adrian Hunter wrote:
>> mmc_request_done() is sometimes called from interrupt
>> or other atomic context. Mostly all mmc_request_done()
>> does is complete(), however it contains code to retry
>> on error, which uses ->request(). As the error path
>> is certainly not performance critical, this may be
>> moved to the waiting function mmc_wait_for_req_done().
>>
>> This allows ->request() to use runtime PM get_sync()
>> and guarantee it is never in an atomic context.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Calling back into the host driver directly from mmc_request_done when
> doing error handling were just plain wrong.
>
> This patch is really great, not just for pm_runtime issues!
>
> Acked-by: Ulf Hansson <ulf.hansson@stericsson.com>
Pushed to mmc-next for 3.2. Thanks!
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-10-10 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 12:33 [PATCH 0/2] mmc: sdhci-pci: add runtime pm support Adrian Hunter
2011-10-03 12:33 ` [PATCH 1/2] mmc: core: move ->request() call from atomic context Adrian Hunter
2011-10-05 13:56 ` Ulf Hansson
2011-10-10 22:05 ` Chris Ball [this message]
2011-10-03 12:33 ` [PATCH 2/2] mmc: sdhci-pci: add runtime pm support Adrian Hunter
2011-10-04 4:44 ` Jaehoon Chung
2011-10-04 6:22 ` Adrian Hunter
2011-10-05 14:59 ` Ulf Hansson
2011-10-06 7:47 ` Adrian Hunter
2011-10-06 14:39 ` Ulf Hansson
2011-10-10 22:07 ` Chris Ball
2011-10-16 1:06 ` Chris Ball
2011-10-16 2:26 ` Chris Ball
2011-10-17 8:19 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wrcclcyd.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.