All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] command.c: Enable auto tab for the editenv command
Date: Fri, 09 Apr 2010 10:18:23 +0200	[thread overview]
Message-ID: <m2wrwhnink.fsf@ohwell.denx.de> (raw)
In-Reply-To: <D0B748CCD5DF144CA5C56A9D860A3134F5CB25@men-exch1.intra.men.de> ("Ralf Trübenbach"'s message of "Thu, 8 Apr 2010 17:40:31 +0200")

Hi Ralf,

> Enable the auto completion (with TAB) of the environment variable name 
> after the editenv command.
>
> Signed-off-by: Ralf Tr?benbach <ralf.truebenbach@men.de>

The idea looks good, but the patch as such is not usable:

[dzu at pollux u-boot-testing (misc-fixes)]$ git am -3 -u ~/p1
Applying: command.c: Enable auto tab for the editenv command
error: command.c: does not exist in index
fatal: sha1 information is lacking or useless (command.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 command.c: Enable auto tab for the editenv command
When you have resolved this problem run "git am -3 --resolved".
If you would prefer to skip this patch, instead run "git am -3 --skip".
To restore the original branch and stop patching run "git am -3 --abort".
[dzu at pollux u-boot-testing (misc-fixes|AM)]$ 

How did you create the patch?  Please follow the instructions[1] in
order to make life easier for everybody.

> ---
>
> === modified file 'common/command.c' (properties changed: -x to +x)

This also looks strange - we certainly don't want execute rights on
source files.

> --- common/command.c    2009-11-22 23:06:11 +0000
> +++ common/command.c    2010-04-08 15:12:44 +0000
> @@ -188,6 +188,9 @@
>
>  void install_auto_complete(void)
>  {
> +#if defined(CONFIG_CMD_EDITENV)
> +       install_auto_complete_handler("editenv", var_complete);
> +#endif
>         install_auto_complete_handler("printenv", var_complete);
>         install_auto_complete_handler("setenv", var_complete);
>  #if defined(CONFIG_CMD_RUN)

Cheers
  Detlev

[1] http://www.denx.de/wiki/U-Boot/Patches

-- 
Per Anhalter durch die Galaxis hat den gewissen Effekt,  den auch eine Sendung
von Monty Python ausl?st;  es l??t alles, was direkt danach in Radio, im Fern-
sehen oder sonstwo auftaucht, absolut l?cherlich wirken. Es hat dieses gewisse
Etwas, das alles in einem gereinigten Licht erscheinen l??t.  - Robert Cushman
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2010-04-09  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 15:40 [U-Boot] [PATCH] command.c: Enable auto tab for the editenv command Ralf Trübenbach
2010-04-09  8:18 ` Detlev Zundel [this message]
2010-04-09  8:26   ` Trübenbach Ralf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wrwhnink.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.