All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fiona Behrens <me@kloenk.dev>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Boris-Chengbiao Zhou" <bobo1239@web.de>,
	"Kees Cook" <kees@kernel.org>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Lukas Wirth" <lukas.wirth@ferrous-systems.com>
Subject: Re: [PATCH v2 1/7] scripts: generate_rust_analyzer.py: add missing whitespace
Date: Wed, 12 Mar 2025 20:00:36 +0100	[thread overview]
Message-ID: <m2y0xaysyz.fsf@kloenk.dev> (raw)
In-Reply-To: <20250311-rust-analyzer-host-v2-1-30220e116511@gmail.com> (Tamir Duberstein's message of "Tue, 11 Mar 2025 21:17:22 -0400")

Tamir Duberstein <tamird@gmail.com> writes:

> Add a space before the `/` operator for consistency with surrounding
> code and code formatting tools. Add a second newline between top-level
> items in accordance with PEP 8[1]:
>
>> Surround top-level function and class definitions with two blank
> lines.
>
> This change was made by a code formatting tool.
>
> Link: https://peps.python.org/pep-0008/ [1]
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Fiona Behrens <me@kloenk.dev>

> ---
>  scripts/generate_rust_analyzer.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index adae71544cbd..15a690ae2edb 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -103,7 +103,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs):
>      ):
>          append_crate(
>              display_name,
> -            srctree / "rust"/ display_name / "lib.rs",
> +            srctree / "rust" / display_name / "lib.rs",
>              deps,
>              cfg=cfg,
>          )
> @@ -178,5 +178,6 @@ def main():
>  
>      json.dump(rust_project, sys.stdout, sort_keys=True, indent=4)
>  
> +
>  if __name__ == "__main__":
>      main()

  reply	other threads:[~2025-03-12 19:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  1:17 [PATCH v2 0/7] rust: generate_rust_analyzer.py: define host crates Tamir Duberstein
2025-03-12  1:17 ` [PATCH v2 1/7] scripts: generate_rust_analyzer.py: add missing whitespace Tamir Duberstein
2025-03-12 19:00   ` Fiona Behrens [this message]
2025-03-12  1:17 ` [PATCH v2 2/7] scripts: generate_rust_analyzer.py: use double quotes Tamir Duberstein
2025-03-12 19:01   ` Fiona Behrens
2025-03-12  1:17 ` [PATCH v2 3/7] scripts: generate_rust_analyzer.py: add trailing comma Tamir Duberstein
2025-03-12 19:02   ` Fiona Behrens
2025-03-12  1:17 ` [PATCH v2 4/7] scripts: generate_rust_analyzer.py: add type hints Tamir Duberstein
2025-03-15 12:20   ` Tamir Duberstein
2025-03-19 21:25   ` Trevor Gross
2025-03-19 22:25     ` Tamir Duberstein
2025-03-12  1:17 ` [PATCH v2 5/7] scripts: generate_rust_analyzer.py: use str(pathlib.Path) Tamir Duberstein
2025-03-12 19:04   ` Fiona Behrens
2025-03-12  1:17 ` [PATCH v2 6/7] scripts: generate_rust_analyzer.py: identify crates explicitly Tamir Duberstein
2025-03-12 19:07   ` Fiona Behrens
2025-03-12  1:17 ` [PATCH v2 7/7] scripts: generate_rust_analyzer.py: define host crates Tamir Duberstein
2025-03-12 19:09   ` Fiona Behrens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2y0xaysyz.fsf@kloenk.dev \
    --to=me@kloenk.dev \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=bobo1239@web.de \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.wirth@ferrous-systems.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@gmail.com \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.