From: Donald Hunter <donald.hunter@gmail.com>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
donald.hunter@redhat.com
Subject: Re: [PATCH net-next v1 2/2] netlink: specs: Add a spec for FIB rule management
Date: Tue, 05 Nov 2024 11:10:10 +0000 [thread overview]
Message-ID: <m2y11yueb1.fsf@gmail.com> (raw)
In-Reply-To: <ZykWTs9a3EqJ3nz5@mini-arch> (Stanislav Fomichev's message of "Mon, 4 Nov 2024 10:45:34 -0800")
Stanislav Fomichev <stfomichev@gmail.com> writes:
>> + name: fib-rule-uid-range
>> + type: struct
>> + members:
>> + -
>> + name: start
>> + type: u16
>> + -
>> + name: end
>> + type: u16
>
> Should be u32?
>
> struct fib_rule_uid_range {
> __u32 start;
> __u32 end;
> };
Ah, well spotted. Looks like I didn't fix up a copy-paste from
fib-rule-port-range.
Thanks!
> Otherwise, both patches look good:
>
> Acked-by: Stanislav Fomichev <sdf@fomichev.me>
prev parent reply other threads:[~2024-11-05 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 16:53 [PATCH net-next v1 0/2] netlink: specs: Add neigh and rule YNL specs Donald Hunter
2024-11-04 16:53 ` [PATCH net-next v1 1/2] netlink: specs: Add a spec for neighbor tables in rtnetlink Donald Hunter
2024-11-04 16:53 ` [PATCH net-next v1 2/2] netlink: specs: Add a spec for FIB rule management Donald Hunter
2024-11-04 18:24 ` Ido Schimmel
2024-11-05 11:06 ` Donald Hunter
2024-11-04 18:45 ` Stanislav Fomichev
2024-11-05 11:10 ` Donald Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y11yueb1.fsf@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.