All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Hopps <chopps@chopps.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Antony Antony <antony.antony@secunet.com>,
	David Ahern <dsahern@gmail.com>,
	netdev@vger.kernel.org, devel@linux-ipsec.org,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Eyal Birger <eyal.birger@gmail.com>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	Sabrina Dubroca <sd@queasysnail.net>,
	Christian Hopps <chopps@chopps.org>
Subject: Re: [PATCH RFC iproute2-next 2/3] xfrm: support xfrm SA direction attribute
Date: Wed, 22 May 2024 05:26:13 -0400	[thread overview]
Message-ID: <m2y18242oz.fsf@ja.int.chopps.org> (raw)
In-Reply-To: <20240519155843.2fc8e95a@hermes.local>

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]


Stephen Hemminger <stephen@networkplumber.org> writes:

> On Sun, 19 May 2024 20:37:23 +0200
> Antony Antony <antony.antony@secunet.com> wrote:
>
>> +	if (tb[XFRMA_SA_DIR]) {
>> +		__u8 dir = rta_getattr_u8(tb[XFRMA_SA_DIR]);
>> +
>> +		fprintf(fp, "\tdir ");
>> +		if (dir == XFRM_SA_DIR_IN)
>> +			fprintf(fp, "in");
>> +		else if (dir == XFRM_SA_DIR_OUT)
>> +			fprintf(fp, "out");
>> +		else
>> +			fprintf(fp, " %d", dir);
>> +		fprintf(fp, "%s", _SL_);
>> +	}
>
> JSON output support please

I would think this should be a different patchset since it would be totally new for iproute xfrm, right?

Thanks,
Chris.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2024-05-22  9:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-19 18:36 [PATCH RFC iproute2-next 0/3] xfrm: Add support for SA direction and output cleanup Antony Antony
2024-05-19 18:37 ` [PATCH RFC iproute2-next 1/3] uapi: Update kernel headers xfrm.h Antony Antony
2024-05-19 18:37 ` [PATCH RFC iproute2-next 2/3] xfrm: support xfrm SA direction attribute Antony Antony
2024-05-19 22:58   ` Stephen Hemminger
2024-05-22  9:26     ` Christian Hopps [this message]
2024-05-23 14:56       ` David Ahern
2024-05-19 18:37 ` [PATCH RFC iproute2-next 3/3] xfrm: update ip xfrm state output for SA with " Antony Antony
2024-05-19 22:59   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2y18242oz.fsf@ja.int.chopps.org \
    --to=chopps@chopps.org \
    --cc=antony.antony@secunet.com \
    --cc=devel@linux-ipsec.org \
    --cc=dsahern@gmail.com \
    --cc=eyal.birger@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=sd@queasysnail.net \
    --cc=steffen.klassert@secunet.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.