All of lore.kernel.org
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] ppc4xx/fdt/flash: Change fdt_fixup_nor_flash_node() to not rely on cs size
Date: Thu, 23 Sep 2010 10:21:23 +0200	[thread overview]
Message-ID: <m2y6asswe4.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1285083088-13049-1-git-send-email-sr@denx.de> (Stefan Roese's message of "Tue, 21 Sep 2010 17:31:28 +0200")

Hi Stefan,

> This patch changes the behaviour of the fdt_fixup_nor_flash_node()
> function. Now it doesn't patch the size of the "reg" property with the
> chip-select size, but with the size returned from the new function
> flash_get_bank_size(). This function will return per weak default the
> flash size of the bank (bank = chip-select numer) detected by the flash
> driver. If this does not fit your needs, this function may be overridden
> by a board specific one.
>
> For this the parameters needed to be changed. So I intentionally squashed
> the PPC4xx stuff using this routine into this patch. Otherwise it would
> not be git-bisectable anymore.
>
> The board specific function for the AMCC/APM Ebony eval board is now
> included in this patch version.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Gerald Van Baren <vanbaren@cideas.com>
> Cc: Wolfgang Denk <wd@denx.de>
>
> ppc4xx: Add board specific function to return the detected flash size
>
> This function will be called to fixup size of the "reg" property of the
> NOR flash device tree nodes. Ebony can't use the weak default, since
> it has a special chip-select to bank-number binding.
>
> Signed-off-by: Stefan Roese <sr@denx.de>

Tested-by: Detlev Zundel <dzu@denx.de>

For the negative test yesterday I indeed used the wrong branch, sorry
for the noise.

Cheers
  Detlev

-- 
Computers are useless. They can only give you answers.
             -- Pablo Picasso
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

      parent reply	other threads:[~2010-09-23  8:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 15:31 [U-Boot] [PATCH v3] ppc4xx/fdt/flash: Change fdt_fixup_nor_flash_node() to not rely on cs size Stefan Roese
2010-09-22  8:30 ` Stefan Roese
2010-09-22 15:37 ` Detlev Zundel
2010-09-22 16:50   ` Stefan Roese
2010-09-23  8:21 ` Detlev Zundel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2y6asswe4.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.