From: Andreas Schwab <schwab@linux-m68k.org>
To: Andrea Gelmini <andrea.gelmini@gelma.net>
Cc: Philip Blundell <philb@gnu.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH 159/199] arch/m68k/hp300/hp300map.map: Checkpatch cleanup
Date: Sun, 06 Jun 2010 13:30:16 +0200 [thread overview]
Message-ID: <m2y6esqtyv.fsf@igel.home> (raw)
In-Reply-To: <1274644930-26600-11-git-send-email-andrea.gelmini@gelma.net> (Andrea Gelmini's message of "Sun, 23 May 2010 22:01:55 +0200")
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 808 bytes --]
Andrea Gelmini <andrea.gelmini@gelma.net> writes:
> diff --git a/arch/m68k/hp300/hp300map.map b/arch/m68k/hp300/hp300map.map
> index 6b45f0a..621c076 100644
> --- a/arch/m68k/hp300/hp300map.map
> +++ b/arch/m68k/hp300/hp300map.map
> @@ -182,71 +182,71 @@ string Prior = "\033[5~"
> string Next = "\033[6~"
> string Macro = "\033[M"
> string Pause = "\033[P"
> -compose '`' 'A' to 'À'
[...]
> +compose '`' 'A' to 'À'
This is obviously wrong. The composed character is supposed to be a
single latin-1 character (namely '\300').
A patch subject containing "checkpatch" should always ring the alarm
bells.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-06-06 11:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 20:01 [PATCH 149/199] arch/ia64/hp/sim/boot/ssc.h: Checkpatch cleanup Andrea Gelmini
2010-05-23 20:01 ` [PATCH 159/199] arch/m68k/hp300/hp300map.map: " Andrea Gelmini
2010-06-06 11:08 ` Geert Uytterhoeven
2010-06-06 11:30 ` Andreas Schwab [this message]
2010-06-06 11:48 ` Geert Uytterhoeven
2010-05-23 20:01 ` [PATCH 160/199] arch/m68k/sun3/leds.c: " Andrea Gelmini
2010-05-23 20:01 ` [PATCH 172/199] arch/parisc/kernel/pa7300lc.c: " Andrea Gelmini
2010-05-23 20:02 ` [PATCH 173/199] arch/parisc/kernel/sys32.h: " Andrea Gelmini
2010-05-23 20:02 ` [PATCH 174/199] arch/parisc/lib/io.c: " Andrea Gelmini
2010-05-23 20:02 ` [PATCH 175/199] arch/parisc/lib/memset.c: " Andrea Gelmini
2010-05-23 20:02 ` [PATCH 176/199] arch/parisc/math-emu/driver.c: " Andrea Gelmini
2010-05-23 20:02 ` [PATCH 177/199] arch/parisc/math-emu/fpbits.h: " Andrea Gelmini
2010-05-23 20:02 ` [PATCH 178/199] arch/s390/crypto/crypto_des.h: " Andrea Gelmini
2010-05-26 0:41 ` Herbert Xu
2010-05-23 20:02 ` [uml-devel] [PATCH 183/199] arch/um/os-Linux/drivers/Makefile: " Andrea Gelmini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y6esqtyv.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=andrea.gelmini@gelma.net \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=philb@gnu.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.